From: "Gary Guo" <gary@garyguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Gary Guo" <gary@garyguo.net>
Cc: "Thiébaud Weksteen" <tweek@google.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Daniel Gomez" <da.gomez@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Aaron Tomlin" <atomlin@atomlin.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: macros: allow non-ASCII characters in `authors`
Date: Wed, 30 Sep 2026 16:37:27 +0100 [thread overview]
Message-ID: <DLSRGVBPWMXX.1LAWUQHDYKLCV@garyguo.net> (raw)
In-Reply-To: <CANiq72m=rhBDJSSPBZ3yXb_r0jiCq7f8KOy+Fs1k8SzWJUwkhw@mail.gmail.com>
On Wed Sep 30, 2026 at 3:54 PM BST, Miguel Ojeda wrote:
> On Wed, Sep 30, 2026 at 3:16 PM Gary Guo <gary@garyguo.net> wrote:
>>
>> I'm not sure that this should be considered a fix. More like a feature.
>
> Yeah, I had the same thought, but given we discussed the topic in the
> past and we supported non-ASCII on purpose on commit b13c9880f909
> ("rust: macros: take string literals in `module!`"), I thought it
> counted as such (that is why I mentioned it was unintentional in my
> previous message).
Ah, that's my patch. It had been completely paged out from my memory. In that
case this is indeed a fix.
I don't think it's worth tagging stable though. It's not something worth putting
effort backporting, but if AUTOSEL picked it via the fixes tag it doesn't hurt
either.
Best,
Gary
next prev parent reply other threads:[~2026-09-30 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 5:11 Thiébaud Weksteen
2026-09-17 7:20 ` Gary Guo
2026-09-25 12:36 ` Petr Pavlu
2026-09-25 12:49 ` Gary Guo
2026-10-01 13:37 ` Petr Pavlu
2026-09-30 12:13 ` Miguel Ojeda
2026-09-30 13:16 ` Gary Guo
2026-09-30 14:54 ` Miguel Ojeda
2026-09-30 15:37 ` Gary Guo [this message]
2026-09-30 15:45 ` Miguel Ojeda
2026-10-01 13:40 ` Petr Pavlu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLSRGVBPWMXX.1LAWUQHDYKLCV@garyguo.net \
--to=gary@garyguo.net \
--cc=aliceryhl@google.com \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®