mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Brendan Jackman" <brendan.jackman@linux.dev>
To: "Gregory Price" <gourry@gourry.net>, <linux-mm@kvack.org>,
	<brendan.jackman@linux.dev>
Cc: <linux-kernel@vger.kernel.org>, <kernel-team@meta.com>,
	<akpm@linux-foundation.org>, <vbabka@kernel.org>,
	<surenb@google.com>, <mhocko@suse.com>, <hannes@cmpxchg.org>,
	<ziy@nvidia.com>, <david@kernel.org>, <ljs@kernel.org>,
	<liam@infradead.org>, <rppt@kernel.org>,
	<baolin.wang@linux.alibaba.com>, <nico.pache@linux.dev>,
	<ryan.roberts@arm.com>, <dev.jain@arm.com>, <baohua@kernel.org>,
	<lance.yang@linux.dev>, <usama.arif@linux.dev>, <kas@kernel.org>,
	<matthew.brost@intel.com>, <joshua.hahnjy@gmail.com>,
	<rakie.kim@sk.com>, <byungchul@sk.com>,
	<ying.huang@linux.alibaba.com>, <apopple@nvidia.com>
Subject: Re: [PATCH] mm/page_alloc: let the bulk and folio allocators carry alloc_flags
Date: Fri, 02 Oct 2026 11:52:22 +0100	[thread overview]
Message-ID: <DLUANOHBUP9C.14W0G57BHYIMF@linux.dev> (raw)
In-Reply-To: <aqgjUJWVUS_nx20i@gourry-fedora-PF4VCD3F>

On Mon Sep 14, 2026 at 5:54 PM BST, Gregory Price wrote:
> On Mon, Sep 14, 2026 at 11:51:14AM -0400, Gregory Price wrote:
>> __alloc_pages_noprof() takes an explicit alloc_flags, but the bulk and
>> folio entry points do not, so callers cannot select allocator behaviour
>> (e.g. an alternate zonelist) through them.
>> 
>> Thread alloc_flags through both, matching __alloc_pages_noprof(), and
>> keep the flag-carrying primitives mm-internal (page_alloc.h) so the
>> public gfp.h wrappers stay flag-free:
>> 
>>  - add __alloc_pages_bulk_noprof(gfp, ..., alloc_flags) in page_alloc.h
>>    alloc_pages_bulk_noprof() becomes a wrapper passing ALLOC_DEFAULT
>> 
>>  - give __folio_alloc_noprof() an alloc_flags parameter and moves
>>    __folio_alloc_node_noprof() moves into page_alloc.h
>>    __folio_alloc_noprof() is no longer exported
>> 
>> No functional change: every caller passes ALLOC_DEFAULT.
>> 
>> Cc: Brendan Jackman <brendan.jackman@linux.dev>
>> Signed-off-by: Gregory Price <gourry@gourry.net>
>> ---
>> 
>> Brendan this will conflict mildly with your ALLOC_UNMAPPED work,
>> because you add an init_alloc_flags call in alloc_pages_bulk_noprof :
>> https://lore.kernel.org/linux-mm/20260726-page_alloc-unmapped-v3-20-6f5729aa9832@google.com/
>> 
>> I wanted to pull this out ahead to try to deal with the conflict.
>> 
>
> Sashiko pointed out some issues that arise from rebasing on the recent
> ALLOC_NOLOCK work, and in a quick review I found a similar slow-path
> fallback issue with the NOBLOCK patch separate of this patch.
>
> Brendan, if you're alright with it, can I pull the NOBLOCK patch out
> ahead into a 2-commit series and I'll add the small fixups?

Hey, sorry about the silence I let LKML pile up rather badly, it's been
quite a month..

Yes I am totally alright with this (glad to see you went ahead).

  reply	other threads:[~2026-10-02 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 15:51 Gregory Price
2026-09-14 16:54 ` Gregory Price
2026-10-02 10:52   ` Brendan Jackman [this message]
2026-10-02 10:59     ` Gregory Price
2026-09-22 13:05 ` Lance Yang
2026-09-23  1:59   ` Gregory Price
2026-09-23  6:32     ` Vlastimil Babka (SUSE)
2026-09-23 15:24       ` Gregory Price
2026-09-23 17:19         ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLUANOHBUP9C.14W0G57BHYIMF@linux.dev \
    --to=brendan.jackman@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=rakie.kim@sk.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®