From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender5-op-o15.zoho.com (sender5-op-o15.zoho.com [165.173.182.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66223290AA; Fri, 2 Oct 2026 15:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790956573; cv=pass; b=rXSWegXTTCNqolUxerjVyGaGOnep9RrGYns7DE+k0BIIfK/TDyEEqWL7/WfFm4Lvbk4T7LV3pcIHf64RP2CFe+US4zTKHWi/xffoPTVUBHcM9UD67arJ6Lsv/tnX+89XRZK6vWdJxsCFQLWo6DS4tJUxtCje1MQHlrv4+VAbO1Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790956573; c=relaxed/simple; bh=3o+/m0Ja7klmizY0LXoCfc4gbqT5/fuW5sYGKawV7YA=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=cQJii617oPwPRqAMGByCxGPLJb4q6eByr8sNFnjnUfLVOTEJMfujnVMnRbUOmowQL/91nmrYhNpuhESh9cK8cStfz3dHqqCftbIrwGZB2yDrvAP1eCxQe0RHlP73MbVA0v2AJlCAt70Br4ApbaEBirAqbkT8xMWBWa0RAgYZ9CM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech; spf=pass smtp.mailfrom=pigmoral.tech; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b=eIXcs4O9; arc=pass smtp.client-ip=165.173.182.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b="eIXcs4O9" ARC-Seal: i=1; a=rsa-sha256; t=1790956548; cv=none; d=zohomail.com; s=zohoarc; b=mKtMMk5AjJR7g3kCzeJHSQp3Xuaf4BC9Txxg7bumRH/cO2iqz3DWC+tesvsX1Vz1cgofK5kCx3luiKYLjKT8jBZt9ZJBEfs1x9Yn8YqKROjA6KTmgd1/J1+tRO0hDX7ouUGLGk5LViV/QosCzilkyS4t8RWKztrPoP0wTfMLxEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790956548; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=nGdebKi33JOCANGOuNqNBIPtdhflulaW1yf0wVEOqV4=; b=Z5HLRglxLHn2BnfSbM7xrP2rTwaaV2Q8pl2JpHBevh3Qh9WBfNbHK3p8WvH9cR9No1u8gG2vu3lHI7B/4fKFaVtPhEwne78eXDAhItJFq3oQRwygnvdpWkg3iWT/GLYl9XIJHF+Io2w/LJuDYif6uSrH6/WujGfG4XZqRnZOksY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=pigmoral.tech; spf=pass smtp.mailfrom=junhui.liu@pigmoral.tech; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790956548; s=zmail; d=pigmoral.tech; i=junhui.liu@pigmoral.tech; h=Mime-Version:Content-Transfer-Encoding:Content-Type:Date:Date:Message-Id:Message-Id:To:To:Cc:Cc:Subject:Subject:From:From:In-Reply-To:Reply-To; bh=nGdebKi33JOCANGOuNqNBIPtdhflulaW1yf0wVEOqV4=; b=eIXcs4O9jOeiEoATsNM81XHbAzZvN6nqpdRrZCE+hmPYpenOgNeBKcYiHAIoN+xE diaqzg5vByF2VOVvxWvVqbi1FwuxutD9Cx6dL5P5pBCGacu3+Z4y4QCLYGAXTLNNO9s V8+kHiuQ9nbC59l4NLOVeJU5vFVrI+3VcenyqZqM= Received: by smtp.zohomail.com with SMTPS id 1790956546300716.3663133196663; Fri, 2 Oct 2026 08:55:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 02 Oct 2026 23:55:38 +0800 Message-Id: To: "Conor Dooley" , "Junhui Liu" Cc: "Stephen Boyd" , "Brian Masney" , "Jerome Brunet" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Conor Dooley" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Brian Masney" , "Yixun Lan" , , , , , "linux-riscv" Subject: Re: [PATCH 1/2] dt-bindings: clock: anlogic,dr1v90-cru: make external clocks optional From: "Junhui Liu" X-Mailer: aerc 0.22.0 References: <20261002-dr1v90-cru-dt-fix-v1-0-c3e0b5d4c30d@pigmoral.tech> <20261002-dr1v90-cru-dt-fix-v1-1-c3e0b5d4c30d@pigmoral.tech> <20261002-oozy-reversal-e65157724bc3@wendy> In-Reply-To: <20261002-oozy-reversal-e65157724bc3@wendy> X-ZohoMailClient: External Hi Conor, On Fri Oct 2, 2026 at 3:17 PM CST, Conor Dooley wrote: > On Fri, Oct 02, 2026 at 02:07:00PM +0800, Junhui Liu wrote: >> The external CAN and WDT clocks are optional inputs routed from the >> board; the main oscillator is the only required clock. The binding >> currently requires all three clocks, which forces device trees to add >> stub fixed-clock nodes without a clock-frequency to satisfy it. >>=20 >> Allow the clocks and clock-names properties to contain just "osc", >> optionally followed by either or both of "can_ext" and "wdt_ext". >>=20 >> Fixes: 155d900e4c7d ("dt-bindings: clock: add Anlogic DR1V90 CRU") >> Signed-off-by: Junhui Liu >> --- >> .../bindings/clock/anlogic,dr1v90-cru.yaml | 24 +++++++++++++++= ------- >> 1 file changed, 17 insertions(+), 7 deletions(-) >>=20 >> diff --git a/Documentation/devicetree/bindings/clock/anlogic,dr1v90-cru.= yaml b/Documentation/devicetree/bindings/clock/anlogic,dr1v90-cru.yaml >> index 11a92588e494..8bd7b78a58d8 100644 >> --- a/Documentation/devicetree/bindings/clock/anlogic,dr1v90-cru.yaml >> +++ b/Documentation/devicetree/bindings/clock/anlogic,dr1v90-cru.yaml >> @@ -17,16 +17,26 @@ properties: >> maxItems: 1 >> =20 >> clocks: >> - items: >> - - description: Main oscillator >> - - description: External CAN clock >> - - description: External WDT clock >> + minItems: 1 >> + maxItems: 3 >> + description: >> + The main oscillator is always required. An external CAN clock and= an >> + external WDT clock may additionally be provided if the board rout= es these >> + clocks to the SoC. >> =20 >> clock-names: >> - items: >> + oneOf: >> - const: osc >> - - const: can_ext >> - - const: wdt_ext >> + - items: >> + - const: osc >> + - const: can_ext >> + - items: >> + - const: osc >> + - const: wdt_ext >> + - items: >> + - const: osc >> + - const: can_ext >> + - const: wdt_ext > > This need not be so complicated. The following should do the trick: > > clock-names: > minItems: 1 > items: > - const: osc > - enum: [can_ext, wdt_ext] > - const: wdt_ext Thanks for showing me the simpler way to express this. I will update it in v2. > > pwbot: changes-requested > >> =20 >> "#clock-cells": >> const: 1 >>=20 >> --=20 >> 2.55.0 >>=20 --=20 Best regards, Junhui Liu