mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pranav Desai" <contact.pranavdesai@gmail.com>
To: "Greg KH" <gregkh@linuxfoundation.org>,
	"Pranav Desai" <contact.pranavdesai@gmail.com>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: replace uint with u32 in hal_intf.[ch]
Date: Wed, 07 Oct 2026 18:01:49 +0530	[thread overview]
Message-ID: <DLYLWJJD9EC0.3CLCLL4O7K9KC@gmail.com> (raw)
In-Reply-To: <2026100644-willing-nucleus-82ce@gregkh>

> That's very odd, shouldn't this be 'int' and return either 0 for
> success, or -ERROR value for an error?

Hi Greg,

The driver's custom _SUCCESS (1) and _FAIL (0) macros are currently hardcoded into the caller logic
across multiple files. Changing rtw_hal_init() to return standard error codes in this patch would invert the
caller logic and cause regressions.

Replacing the _SUCCESS/_FAIL architecture requires a driver-wide refactor. To avoid scope creep, I have dropped
the hal_intf.c changes from this series entirely.

I just submitted v3 focusing exclusively on explicitly typing variables in rtw_security.c. I will address the
_SUCCESS/_FAIL macro teardown in a separate patch series.


Thanks,

Pranav

  reply	other threads:[~2026-10-07 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 20:07 [PATCH v2 0/2] staging: rtl8723bs: fix uint types in hal_intf and rtw_security Pranav Desai
2026-10-06 20:07 ` [PATCH v2 1/2] staging: rtl8723bs: replace uint with u32 in hal_intf.[ch] Pranav Desai
2026-10-06 21:07   ` Greg KH
2026-10-07 12:31     ` Pranav Desai [this message]
2026-10-06 20:07 ` [PATCH v2 2/2] staging: rtl8723bs: replace uint with explicit types in rtw_security.c Pranav Desai
2026-10-06 21:06   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLYLWJJD9EC0.3CLCLL4O7K9KC@gmail.com \
    --to=contact.pranavdesai@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®