From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224nalPUT8HI8ClHuwlZ/LwzQbBarzBEDGt/kwRyFNFnIMnzVwYMQ5AHXHq/05iZPnseg6lB ARC-Seal: i=1; a=rsa-sha256; t=1517421800; cv=none; d=google.com; s=arc-20160816; b=feqIr3A/8pdClbvwgBjlX69OTUQqsfYY0MPgFKbq4UygUEfMMmlO7G4sfS4Vsi9r93 9qbR740GL8HbqLcbbzWJyudf0D1t5qgh7CYKSQgURqaQurWSx/HiVMRRk6xq9jc4/Tmj wb8bxPpbhs0jhPvPCUgJ7L9iTT0WteFUCEfmCiVK4spY7ZaxCaC+1zL7fdc71KXjxyRv Jift042eviwmrQwm1sdq+/Z5h7ZCXIimrRrrkN7i3vAjiNBSKR53HzPs1qQAsp+/StdI iMba9z0NLZiy64HXECg9uB+wd3aF9ty4aatnnQSdLlcaXS9fIB8Rly3ZBEbrjNbqVxFi LJ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=jC/ytgrFbj1BFQkBp30Eq1sTSpxbzwOnjkByoetMOIg=; b=kEYWRY00HpJgxmFpc1ck3xUYXD+I2GvQAVyB/z+osXebN11KhqXOS6Bq7mJjaIV1HU EnPF/R9v6wSujoH/csn9bGgxPOW1C4jG0BGNq9Z3AzVY0JjCpEC9bIq19vbveA4nfLQ7 xK7sYAKCF5bRRnn8cqrpmbJo3jQS0a2z9NDm/mfz2eS1ZReuSOyNi3qD6OD5JBo+diAB JcGhKOGfwV6JvJzKw88OlicC332tZQuiKpFa2aGpenFpx9s2lSIHxm4LpCH+yv0CC3Oz ho7bBwOEa2MfLNzSv136VFNZcH+Sg40fqG64EuQ1spITSpBFUT4Tt+Tbhwbyo5ASKcyw BGGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=mQpTrj6R; spf=pass (google.com: domain of jollys@xilinx.com designates 104.47.42.51 as permitted sender) smtp.mailfrom=JOLLYS@xilinx.com Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=mQpTrj6R; spf=pass (google.com: domain of jollys@xilinx.com designates 104.47.42.51 as permitted sender) smtp.mailfrom=JOLLYS@xilinx.com From: Jolly Shah To: Rob Herring CC: "ard.biesheuvel@linaro.org" , "mingo@kernel.org" , "gregkh@linuxfoundation.org" , "matt@codeblueprint.co.uk" , "sudeep.holla@arm.com" , "hkallweit1@gmail.com" , "keescook@chromium.org" , "dmitry.torokhov@gmail.com" , "michal.simek@xilinx.com" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Rajan Vaja Subject: RE: [PATCH v3 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware Thread-Topic: [PATCH v3 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware Thread-Index: AQHTlWomdmmvreQR6kiWwxGfbK0z8aOMrwQAgAGhGdA= Date: Wed, 31 Jan 2018 18:03:14 +0000 Message-ID: References: <1516836074-4149-1-git-send-email-jollys@xilinx.com> <1516836074-4149-2-git-send-email-jollys@xilinx.com> <20180130170818.tz4hoqvyekrl7uio@rob-hp-laptop> In-Reply-To: <20180130170818.tz4hoqvyekrl7uio@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=JOLLYS@xilinx.com; x-originating-ip: [73.162.184.228] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM2PR0201MB0733;7:add0xMe+rSNSpDVxzkX1vnCAbzCGlGg8n/0Z8WZ2Ck/wC2J89zPu/Y1OFK526Qvl9bnlAO3jVG+qmokSRIk7OV+doNWLICWhTsh68PKMFOnshLLgmaAg2rMBr8+2IQy19f3NVFLL8TLhjmX5jSgqurJsbAHOLxmHuuOsG0baknBcelUcARclHbnkvXk/5GM7Yr3lY3NaXefPaVktCb+F2xLFetFCjsohr76ye679wV9Cp2J7Z8rgyMQScL+OrNmF x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(396003)(39380400002)(376002)(39860400002)(346002)(366004)(189003)(13464003)(51914003)(199004)(3846002)(7696005)(6116002)(6436002)(66066001)(76176011)(102836004)(229853002)(33656002)(305945005)(7736002)(3660700001)(6506007)(53546011)(74316002)(2900100001)(106356001)(4326008)(6916009)(14454004)(2950100002)(478600001)(7416002)(72206003)(39060400002)(107886003)(6246003)(68736007)(5250100002)(8676002)(81166006)(81156014)(5660300001)(8936002)(25786009)(105586002)(99286004)(2906002)(54906003)(55016002)(97736004)(53936002)(316002)(9686003)(26005)(3280700002)(86362001)(186003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0201MB0733;H:DM2PR0201MB0767.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8f18fdf9-4186-493f-5084-08d568d4e647 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:DM2PR0201MB0733; x-ms-traffictypediagnostic: DM2PR0201MB0733: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(85827821059158)(258649278758335)(192813158149592); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(3002001)(93006095)(93001095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:DM2PR0201MB0733;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0733; x-forefront-prvs: 056929CBB8 x-microsoft-antispam-message-info: bx1kznMjhG0+bmJ+piI7ZYVpT0IC1/uPZk5j6/HUK2wE8nvezvPlLQ7iI2K0DGTYRyCzMsV9cfvzigLEfaekjw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f18fdf9-4186-493f-5084-08d568d4e647 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 18:03:14.6280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0733 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590517943929452186?= X-GMAIL-MSGID: =?utf-8?q?1591132081976845381?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Rob, Thanks for the review, > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Tuesday, January 30, 2018 9:08 AM > To: Jolly Shah > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; > gregkh@linuxfoundation.org; matt@codeblueprint.co.uk; > sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org; > dmitry.torokhov@gmail.com; michal.simek@xilinx.com; > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; Jolly Shah > ; Rajan Vaja > Subject: Re: [PATCH v3 1/4] dt-bindings: firmware: Add bindings for ZynqM= P > firmware >=20 > On Wed, Jan 24, 2018 at 03:21:11PM -0800, Jolly Shah wrote: > > Add documentation to describe Xilinx ZynqMP firmware driver bindings. > > Firmware driver provides an interface to firmware APIs. Interface APIs > > can be used by any driver to communicate to PMUFW (Platform Management > > Unit). > > > > Signed-off-by: Jolly Shah > > Signed-off-by: Rajan Vaja > > --- > > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 > ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware > > .txt > > > > diff --git > > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmwa > > re.txt > > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmwa > > re.txt > > new file mode 100644 > > index 0000000..a7aaf56 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-fi > > +++ rmware.txt > > @@ -0,0 +1,16 @@ > > +Xilinx Zynq MPSoC Firmware Device Tree Bindings > > + > > +The zynqmp-firmware node describes the interface to platform firmware. >=20 > Please define this a is child of /firmware. > I dint get you. It is already under firmware/xilinx. =20 > Also, some brief summary of what functions the firmware provides would be > nice. >=20 Sure. Will add it in next version. > > + > > +Required properties: > > + - compatible: Must contain: "xlnx,zynqmp-firmware" > > + - method: The method of calling the PM-API firmware layer. > > + Permitted values are: > > + - "smc" : To be used in configurations without a hypervisor > > + - "hvc" : To be used when hypervisor is present >=20 > Do you really need to support hvc? Yes we do support hvc and smc both. >=20 > > + > > +Examples: > > + zynqmp_firmware: zynqmp-firmware { > > + compatible =3D "xlnx,zynqmp-firmware"; > > + method =3D "smc"; > > + }; > > -- > > 2.7.4 > >