From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227E/mu/hGaDKtsYdZpchz17YzZrYmZKRc+GqXD4dQwrh1ZvdMsEngLk3b5yRGwQFJ0CkP+m ARC-Seal: i=1; a=rsa-sha256; t=1516836497; cv=none; d=google.com; s=arc-20160816; b=SNjphroXeWtDtls3uzmefd4GVddILUb8jewMO8arvMYVcET8owhng1Qp6zMEnoiL1i ePjhxtJHDMbDdMPnuBkhzYWYmrrVCUu1OpbjdZK3tPqS9IxMWY9vUOJRelibTYBpucqI Jbd/dhY40x4u3NGc9/b586FlKs69hMbbMa/6eKKxDJbUYrELyA75l+k+Fa7IuVr2NMVM fH5gmXT5ZCc0ONouJAReiKxXenlFTnTZVQxIfxNtH5VAujzzBpzvzM6Iex8BD5reD+zS BsaJV648sVbJIzEY5F+Zp6Ipb/1DI691DMiSkp3FzyhWiTxHUiYLK1FQ7WfSXG3p6Q25 N4dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=iIkPteDNjySorMnr37pHDvgdiUPeoVm5uB5+V2d+Uvk=; b=ygBK+HtDLISksZ32KW7ZmGjpHAy7+dJrtU68uAZnQXYQaGWAvw+HZUaNjBGKzoRH/K nMLu9RD+MmXu0aRp/KKzZjlIeaWAFiwhUnLgg5jXy9j8KTBvRPA2WcBZNNE7J/qk6kx1 K4rXyD/3kecKWSQJhFQmXZhi/fe06Bv8E9LsWzQp+YyRySkO5wkC7Lr4LrHbTnBThO1v x0Fw5jTLQFaD3UZ3l7/ZcskUVIdMsfrF9WtFY3y7/UO3AfTChEyk/HdHzXFmluN66r/e MoV6M6kdddMWZ6ApfJYVRYsVw0jkKq0vccljAIwcUkooOFGgJqiqGmkmOtn92hkHJpuU L8qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=MWW4Bx/a; spf=pass (google.com: domain of jollys@xilinx.com designates 104.47.34.63 as permitted sender) smtp.mailfrom=JOLLYS@xilinx.com Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=MWW4Bx/a; spf=pass (google.com: domain of jollys@xilinx.com designates 104.47.34.63 as permitted sender) smtp.mailfrom=JOLLYS@xilinx.com From: Jolly Shah To: Greg KH CC: "ard.biesheuvel@linaro.org" , "mingo@kernel.org" , "matt@codeblueprint.co.uk" , "sudeep.holla@arm.com" , "hkallweit1@gmail.com" , "keescook@chromium.org" , "dmitry.torokhov@gmail.com" , "michal.simek@xilinx.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Rajan Vaja Subject: RE: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver Thread-Topic: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver Thread-Index: AQHTj9C5tJkts91Bqkm+RPr8yx5ad6OBK22AgAKKrYA= Date: Wed, 24 Jan 2018 23:28:12 +0000 Message-ID: References: <1516220434-22204-1-git-send-email-jollys@xilinx.com> <1516220434-22204-3-git-send-email-jollys@xilinx.com> <20180123083823.GB21463@kroah.com> In-Reply-To: <20180123083823.GB21463@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=JOLLYS@xilinx.com; x-originating-ip: [149.199.62.254] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM2PR0201MB0992;7:jIMnbHWzdkUOo+ACGL2XZwGvCcrJPJJ2qd9EI3pm510TTRMqQGaBXHKhzABzGp5/ipIrCJsTHGTfbkz3pBXU1EYtgD7CypOZsep0iSrDk8mIWiCHx0IB0aBNwhuL6tVuhsp/cScrM14GvPCR7luFpl6BfJYUdp/BweJcvh8auaqSJXhBD+mGk6IADVc1XGZPtkjrRbzMh/e+XKf0sp1A5uLaQzgedbiSHhHzaGskLzkKdu7dva9Py6yqoUkhQFDa x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(39860400002)(366004)(396003)(39380400002)(346002)(376002)(189003)(199004)(13464003)(8936002)(229853002)(33656002)(81166006)(3846002)(26005)(6116002)(8676002)(81156014)(6436002)(9686003)(55016002)(3660700001)(5250100002)(316002)(68736007)(76176011)(54906003)(3280700002)(53936002)(7696005)(478600001)(66066001)(106356001)(6246003)(25786009)(86362001)(39060400002)(72206003)(7416002)(107886003)(2900100001)(53546011)(97736004)(6506007)(105586002)(2950100002)(74316002)(5660300001)(2906002)(4326008)(6916009)(99286004)(102836004)(14454004)(7736002)(305945005)(186003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0201MB0992;H:DM2PR0201MB0767.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: c446e5d8-a65d-4139-9307-08d56382230a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060)(7193020);SRVR:DM2PR0201MB0992; x-ms-traffictypediagnostic: DM2PR0201MB0992: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(85827821059158)(258649278758335)(192813158149592); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231023)(2400081)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:DM2PR0201MB0992;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0992; x-forefront-prvs: 056297E276 x-microsoft-antispam-message-info: UyHuB5N3uCbCBPH7UOu0+ZbCdEJ47E3L5LEG3SBZuVeSc/8XKuBRafVSeLwFXF+49adohq6ggoRBHTWP2IX0RQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: c446e5d8-a65d-4139-9307-08d56382230a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 23:28:12.5711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0992 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589872402265316836?= X-GMAIL-MSGID: =?utf-8?q?1590518347129137975?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Thanks for review Greg, > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, January 23, 2018 12:38 AM > To: Jolly Shah > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk= ; > sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org; > dmitry.torokhov@gmail.com; michal.simek@xilinx.com; robh+dt@kernel.org; > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; Rajan Vaja > ; Jolly Shah > Subject: Re: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmwar= e > driver >=20 > On Wed, Jan 17, 2018 at 12:20:32PM -0800, Jolly Shah wrote: > > This patch is adding communication layer with firmware. > > Firmware driver provides an interface to firmware APIs. > > Interface APIs can be used by any driver to communicate to > > PMUFW(Platform Management Unit). All requests go through ATF. > > > > Signed-off-by: Jolly Shah > > Signed-off-by: Rajan Vaja > > --- > > arch/arm64/Kconfig.platforms | 1 + > > drivers/firmware/Kconfig | 1 + > > drivers/firmware/Makefile | 1 + > > drivers/firmware/xilinx/Kconfig | 4 + > > drivers/firmware/xilinx/Makefile | 4 + > > drivers/firmware/xilinx/zynqmp/Kconfig | 16 + > > drivers/firmware/xilinx/zynqmp/Makefile | 4 + > > drivers/firmware/xilinx/zynqmp/firmware.c | 987 > ++++++++++++++++++++++++ > > include/linux/firmware/xilinx/zynqmp/firmware.h | 570 ++++++++++++++ >=20 > Why does this file need to be in include/linux/ at all? Shouldn't it jus= t live in the > driver-specific subdir? >=20 > thanks, >=20 > greg k-h It is used by multiple drivers so can not live in driver specific subdir. Thanks, Jolly Shah