From: Jolly Shah <JOLLYS@xilinx.com>
To: Julien Thierry <julien.thierry@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rajan Vaja <RAJANV@xilinx.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>
Subject: RE: [PATCH] drivers: firmware: xilinx: Add ZynqMP firmware driver
Date: Thu, 11 Jan 2018 01:13:57 +0000 [thread overview]
Message-ID: <DM2PR0201MB07678276DA8938F5BF5E0A34B8160@DM2PR0201MB0767.namprd02.prod.outlook.com> (raw)
In-Reply-To: <5fbe8626-63be-02c4-b3e5-ba6c99a8d67c@arm.com>
Hi Julien,
Thanks for the review,
> -----Original Message-----
> From: Julien Thierry [mailto:julien.thierry@arm.com]
> Sent: Tuesday, January 09, 2018 6:07 AM
> To: Jolly Shah <JOLLYS@xilinx.com>; ard.biesheuvel@linaro.org;
> mingo@kernel.org; gregkh@linuxfoundation.org; matt@codeblueprint.co.uk;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; michal.simek@xilinx.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Jolly
> Shah <JOLLYS@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>
> Subject: Re: [PATCH] drivers: firmware: xilinx: Add ZynqMP firmware driver
>
> Hi Jolly,
>
> On 08/01/18 22:07, Jolly Shah wrote:
> > This patch is adding communication layer with firmware.
> > Firmware driver provides an interface to firmware APIs.
> > Interface APIs can be used by any driver to communicate to
> > PMUFW(Platform Management Unit). All requests go through ATF.
> > Firmware-debug provides debugfs interface to all APIs.
> > Firmware-ggs provides read/write interface to
> > global storage registers.
> >
> > Signed-off-by: Jolly Shah <jollys@xilinx.com>
> > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > ---
> > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 +
> > arch/arm64/Kconfig.platforms | 1 +
> > drivers/firmware/Kconfig | 1 +
> > drivers/firmware/Makefile | 1 +
> > drivers/firmware/xilinx/Kconfig | 4 +
> > drivers/firmware/xilinx/Makefile | 4 +
> > drivers/firmware/xilinx/zynqmp/Kconfig | 23 +
> > drivers/firmware/xilinx/zynqmp/Makefile | 5 +
> > drivers/firmware/xilinx/zynqmp/firmware-debug.c | 540 +++++++++++
> > drivers/firmware/xilinx/zynqmp/firmware-ggs.c | 298 ++++++
> > drivers/firmware/xilinx/zynqmp/firmware.c | 1024
> ++++++++++++++++++++
> > .../linux/firmware/xilinx/zynqmp/firmware-debug.h | 32 +
> > include/linux/firmware/xilinx/zynqmp/firmware.h | 573 +++++++++++
> > 13 files changed, 2522 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> > create mode 100644 drivers/firmware/xilinx/Kconfig
> > create mode 100644 drivers/firmware/xilinx/Makefile
> > create mode 100644 drivers/firmware/xilinx/zynqmp/Kconfig
> > create mode 100644 drivers/firmware/xilinx/zynqmp/Makefile
> > create mode 100644 drivers/firmware/xilinx/zynqmp/firmware-debug.c
> > create mode 100644 drivers/firmware/xilinx/zynqmp/firmware-ggs.c
> > create mode 100644 drivers/firmware/xilinx/zynqmp/firmware.c
> > create mode 100644 include/linux/firmware/xilinx/zynqmp/firmware-
> debug.h
> > create mode 100644 include/linux/firmware/xilinx/zynqmp/firmware.h
> >
>
> > +
> > +static u32 pm_api_version;
> > +
> > +/**
> > + * zynqmp_pm_get_api_version - Get version number of PMU PM firmware
> > + * @version: Returned version value
> > + *
> > + * Return: Returns status, either success or error+reason
> > + */
> > +static int zynqmp_pm_get_api_version(u32 *version)
> > +{
> > + u32 ret_payload[PAYLOAD_ARG_CNT];
> > +
> > + if (!version)
> > + return zynqmp_pm_ret_code(XST_PM_CONFLICT);
> > +
> > + /* Check is PM API version already verified */
> > + if (pm_api_version > 0) {
> > + *version = pm_api_version;
> > + return XST_PM_SUCCESS;
> > + }
> > + invoke_pm_fn(GET_API_VERSION, 0, 0, 0, 0, ret_payload);
> > + *version = ret_payload[1];
> > +
>
> I think you forgot to save the result to pm_api_version, unless I am
> missing something.
>
Pm_api_version is initialized in init routine. So no need to save it again as version will remain same.
Rest all comments will be fixed in next version.
Thanks,
Jolly Shah
next prev parent reply other threads:[~2018-01-11 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 22:07 Jolly Shah
2018-01-09 12:19 ` Aishwarya Pant
2018-01-11 0:39 ` Jolly Shah
2018-01-09 12:45 ` Philippe Ombredanne
2018-01-09 14:07 ` Julien Thierry
2018-01-11 1:13 ` Jolly Shah [this message]
2018-01-09 14:40 ` Sudeep Holla
2018-01-11 0:35 ` Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM2PR0201MB07678276DA8938F5BF5E0A34B8160@DM2PR0201MB0767.namprd02.prod.outlook.com \
--to=jollys@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=julien.thierry@arm.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®