From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755264AbbBRR1w (ORCPT ); Wed, 18 Feb 2015 12:27:52 -0500 Received: from mail-bl2on0143.outbound.protection.outlook.com ([65.55.169.143]:51376 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753733AbbBRR1u convert rfc822-to-8bit (ORCPT ); Wed, 18 Feb 2015 12:27:50 -0500 From: Jake Oshins To: Dan Carpenter CC: "rafael.j.wysocki@intel.com" , "gregkh@linuxfoundation.org" , KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" Subject: RE: [PATCH 2/3] drivers:hv Convert VMBus and its descendants to PnP Thread-Topic: [PATCH 2/3] drivers:hv Convert VMBus and its descendants to PnP Thread-Index: AQHQSt9iS/osrzZ65U2jz6zK3x/5h5z2NE6AgABtFdA= Date: Wed, 18 Feb 2015 16:55:15 +0000 Message-ID: References: <1424202111-14461-1-git-send-email-jakeo@microsoft.com> <1424202111-14461-2-git-send-email-jakeo@microsoft.com> <20150218102407.GB5206@mwanda> In-Reply-To: <20150218102407.GB5206@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:4898:80e8:ee31::2] authentication-results: oracle.com; dkim=none (message not signed) header.d=none; x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0717; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0717; x-forefront-prvs: 04916EA04C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(51914003)(377454003)(51704005)(13464003)(77156002)(62966003)(2656002)(106116001)(122556002)(86612001)(99286002)(33656002)(86362001)(40100003)(50986999)(76176999)(54356999)(87936001)(19580395003)(19580405001)(46102003)(74316001)(92566002)(102836002)(15975445007)(110136001)(76576001)(2950100001)(2900100001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0717;H:DM2PR0301MB1232.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: microsoft.onmicrosoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2015 16:55:15.0352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0717 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > Sent: Wednesday, February 18, 2015 2:24 AM > To: Jake Oshins > Cc: rafael.j.wysocki@intel.com; gregkh@linuxfoundation.org; KY Srinivasan; > linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > apw@canonical.com; vkuznets@redhat.com > Subject: Re: [PATCH 2/3] drivers:hv Convert VMBus and its descendants to PnP > > On Tue, Feb 17, 2015 at 11:41:50AM -0800, Jake Oshins wrote: > > > > + ret = pnp_add_descendant(child_device_obj->pnp_dev); > > if (ret) > > + goto register_exit; > > + > > + added = TRUE; > > + > > + ret = pnp_activate_dev(child_device_obj->pnp_dev); > > + > > +register_exit: > > + > > + if (ret) { > > + if (added) > > + pnp_remove_descendant(child_device_obj->pnp_dev); > > + free_pnp_descendant(child_device_obj->pnp_dev); > > pr_err("Unable to register child device\n"); > > - else > > + } else > > pr_debug("child device %s registered\n", > > - dev_name(&child_device_obj->device)); > > + dev_name(&child_device_obj->pnp_dev->dev)); > > > > return ret; > > } > > This error handling is horribly ugly and has a bug. Please, read my > essay on how to do error handling properly. > > https://plus.google.com/106378716002406849458/posts/dnanfhQ4mHQ > > 1) Don't do "One Err" style error handling. > 2) Don't twist the success path and the error paths together. > 3) Don't use the "added" variable. > 4) Don't initialize "ret" at the start of the function. > 5) Don't forget to undo pnp_descendant_memory_option() > > It should look something like: > > return 0; > > err_remove_desc: > pnp_remove_descendant(child_device_obj->pnp_dev); > err_remove_option: > if (bytes) > remove_whatever(); > err_free_desc: > free_pnp_descendant(child_device_obj->pnp_dev); > > return ret; > > regards, > dan carpenter Will do. Thanks for the review. -- Jake Oshins