From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755515AbbFLPLS (ORCPT ); Fri, 12 Jun 2015 11:11:18 -0400 Received: from mail-bn1on0116.outbound.protection.outlook.com ([157.56.110.116]:62528 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754935AbbFLPLQ (ORCPT ); Fri, 12 Jun 2015 11:11:16 -0400 From: Jake Oshins To: Paul Bolle CC: "gregkh@linuxfoundation.org" , KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , Mike Ebersol , Haiyang Zhang Subject: RE: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs Thread-Topic: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs Thread-Index: AQHQpGMt5IxKR56iPE6hawK1wDMFR52ojxeAgABqmdA= Date: Fri, 12 Jun 2015 15:11:14 +0000 Message-ID: References: <1434039747-44535-1-git-send-email-jakeo@microsoft.com> <1434039747-44535-7-git-send-email-jakeo@microsoft.com> <1434098643.2271.141.camel@x220> In-Reply-To: <1434098643.2271.141.camel@x220> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: tiscali.nl; dkim=none (message not signed) header.d=none; x-originating-ip: [166.255.16.22] x-microsoft-exchange-diagnostics: 1;DM2PR0301MB1247;3:3ZJy891XBtUpfE5oU0zJ1M2fwCoxJVM4Qs5+66kPDNqtewwZu7LgpUyxyHCcIAHQeWAOsDEkzz/7sG0pVlKB5tVTAaHj7VhrfwkaRiVh6sXko8FJ1npjdfLBuQFZ5ryNzPcshB82HZ64mib5W9ovog==;10:wTyINPmJNBra7St3fhcVhfOH00hvF2quXhctr7ZeJzUyJpQ9xSJ8qPpqSnCTeWbaH9K2sQCRNzfS7TkBvyT3HByzIJLKwb+HNWem9BpyBgA=;6:3Q6Lwa9X1dZR8oAEtcUTriVyKFryAaZ3BxPAc2iH3wHCMVNRNz/UxtbxxO6vRR88 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1247; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401001)(5005006)(520003)(3002001);SRVR:DM2PR0301MB1247;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1247; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(51704005)(377454003)(51444003)(164054003)(13464003)(106116001)(74316001)(66066001)(99286002)(122556002)(40100003)(5002640100001)(19580395003)(46102003)(19580405001)(77156002)(62966003)(2900100001)(102836002)(86362001)(2950100001)(33656002)(76176999)(54356999)(77096005)(92566002)(107886002)(76576001)(2656002)(110136002)(189998001)(87936001)(5001960100002)(50986999)(5003600100002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB1247;H:DM2PR0301MB1232.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2015 15:11:14.1538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1247 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5CFBO3c018095 > -----Original Message----- > From: Paul Bolle [mailto:pebolle@tiscali.nl] > Sent: Friday, June 12, 2015 1:44 AM > To: Jake Oshins > Cc: gregkh@linuxfoundation.org; KY Srinivasan; linux- > kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > apw@canonical.com; vkuznets@redhat.com; linux-pci@vger.kernel.org; > bhelgaas@google.com; Mike Ebersol; Haiyang Zhang > Subject: Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for > Hyper-V VMs > > Greg has already asked you to resend. So here follow a few remarks to > take into account for that resend. > Thank you. I'll fix everything you've mentioned before resending. I do have one more question, below. > > > +EXPORT_SYMBOL(hv_read_config_block); > > > +EXPORT_SYMBOL(hv_write_config_block); > > > +EXPORT_SYMBOL(hv_register_block_invalidate); > > I couldn't spot any users of these exports. Actually, I couldn't even > spot any users of these three functions. Why were they added? > This driver is intended to support both full PCI Express device pass through and also be the basis for SR-IOV networking on top of Hyper-V. These functions would allow somebody trying to make their NIC driver work on top of Hyper-V to exchange messages with their back-end Windows driver. My question is this. How does somebody delivering a platform usually work with the Linux community to deliver enablement code like this? I'm trying to work in the open, and go upstream early (or at least I think that understand what these things mean.) If the community doesn't want functions that have no callers (and I understand that, too) then how should I provide them to the NIC vendors? Thanks, Jake Oshins {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I