From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965786AbbJ0Rfg (ORCPT ); Tue, 27 Oct 2015 13:35:36 -0400 Received: from mail-bn1bbn0101.outbound.protection.outlook.com ([157.56.111.101]:61056 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965134AbbJ0Rfb convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2015 13:35:31 -0400 From: Jake Oshins To: Jiang Liu , "gregkh@linuxfoundation.org" , KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "tglx@linutronix.de" , Haiyang Zhang , "marc.zyngier@arm.com" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" Subject: RE: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally Thread-Topic: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally Thread-Index: AQHREESB895egxCw1UKy7sj0m8g+gJ5+7IEAgACp9BA= Date: Tue, 27 Oct 2015 17:19:48 +0000 Message-ID: References: <1445901339-11924-1-git-send-email-jakeo@microsoft.com> <1445901339-11924-5-git-send-email-jakeo@microsoft.com> <562F2354.8040802@linux.intel.com> In-Reply-To: <562F2354.8040802@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jakeo@microsoft.com; x-originating-ip: [2001:4898:80e8:6::349] x-microsoft-exchange-diagnostics: 1;DM2PR0301MB0781;5:OGXtvbhNiO87mJbJjvBm0ZNEw0cMyfVm2wbzFiQJTL29/qhlC61ViMYXOKBJZ28xNYBfaw5zrEsMgYEa0F/1L/U1tdO6wSvSjpp1fi0eKf/QeRn1Cg4bHGstIQs5AeEdKZJS7mE4DzhsTCAMnpCO5g==;24:qCt1y7nVZktgmvFarVj+KjzFnU9mXstLH+ceARFeU5ZdWZOTzHPyaOdFKWFQ01RRc9/0uiKy/D2vh3G7HA+XIVt5/D7dLEMrOMukjLgtP70=;20:4qKQzU8Si2Cdrcbo7v647Mvb4Eevtyf0qilbbeofxw/Ol65dfv0n3GHwx0k9RrkhjzaWMUiS5cc4lwCQLZxAVw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0781; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(108003899814671); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425024)(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215026)(61426024)(61427024);SRVR:DM2PR0301MB0781;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0781; x-forefront-prvs: 0742443479 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(51914003)(199003)(479174004)(13464003)(377454003)(164054003)(77096005)(102836002)(2501003)(107886002)(5001960100002)(5002640100001)(76576001)(5001770100001)(97736004)(5003600100002)(81156007)(5005710100001)(10290500002)(8990500004)(10400500002)(101416001)(33656002)(2900100001)(1511001)(74316001)(2950100001)(189998001)(87936001)(92566002)(122556002)(105586002)(5004730100002)(50986999)(99286002)(76176999)(2561002)(106356001)(5008740100001)(106116001)(2421001)(5007970100001)(19580395003)(40100003)(10090500001)(11100500001)(19580405001)(86362001)(54356999)(2201001)(86612001)(921003)(3826002)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0781;H:DM2PR0301MB1232.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2015 17:19:48.2860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0781 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jiang Liu [mailto:jiang.liu@linux.intel.com] > Sent: Tuesday, October 27, 2015 12:10 AM > To: Jake Oshins ; gregkh@linuxfoundation.org; KY > Srinivasan ; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > vkuznets@redhat.com; tglx@linutronix.de; Haiyang Zhang > ; marc.zyngier@arm.com; > bhelgaas@google.com; linux-pci@vger.kernel.org > Subject: Re: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI > buses, optionally > > On 2015/10/27 7:15, jakeo@microsoft.com wrote: > > From: Jake Oshins > > > > This patch allows a PCI front-end implementation to supply an > fwnode_handle > > associated with a root PCI bus, optionally. If supplied, the PCI driver > > records this. > > > > This patch supports the next patch in the series, which looks up an IRQ > domain > > through this handle. > Hi JaKeo, > Instead of changing the pci_create_root_bus() interface, > how about packing fwnode into sysdata, then we may > either 1) introduce a helper to retrieve fwnode from sysdata > or 2) set host_bridge->fwnode = sysdata in function > pcibios_root_bridge_prepare. > > Thanks, > Gerry > Thanks for the review. I'll work up a version that uses this suggestion and resend. (I'll respond to your feedback on the other patches, too.) -- Jake Oshins