From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbbINGwf (ORCPT ); Mon, 14 Sep 2015 02:52:35 -0400 Received: from mail-bl2on0113.outbound.protection.outlook.com ([65.55.169.113]:55748 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752483AbbINGvo convert rfc822-to-8bit (ORCPT ); Mon, 14 Sep 2015 02:51:44 -0400 X-Greylist: delayed 12854 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Sep 2015 02:51:44 EDT From: Yuantian Tang To: Fengguang Wu CC: Tejun Heo , "hdegoede@redhat.com" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Thread-Topic: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Thread-Index: AQHQ6uECEB0oY2K4jk6uDrDQBK+S3p40OksAgAKRGhCAAJGcgIAD5tDwgAArdACAAC4XAA== Date: Mon, 14 Sep 2015 06:51:36 +0000 Message-ID: References: <1441790182-20248-1-git-send-email-Yuantian.Tang@freescale.com> <20150909140130.GB22909@mtj.duckdns.org> <20150911135431.GP8114@mtj.duckdns.org> <20150914040456.GA21102@wfg-t540p.sh.intel.com> In-Reply-To: <20150914040456.GA21102@wfg-t540p.sh.intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuantian.Tang@freescale.com; x-originating-ip: [192.88.168.34] x-microsoft-exchange-diagnostics: 1;DM2PR03MB574;5:oIWhI9xavJsCloeI6TItZjanKCvkmIFPxm3hFFBGij0EgraHU8LtFWbW8ajZj+IXSB6tTuyXl9YsDx1R1NuvLrWPToc+0kC9sJKqtLT6hNHr5++9saSzFCGJvLw0OT1AjzDnjIZ8uBUSpL+56WYzKw==;24:FwF4QJ/Jzv2QIw3jEH/XHLFDxCgMveHtsOot+Ek7yFXXeGK0d9f8xleG9yklq49UQcZqkZisXuYHpt4XwDhO00YDoy2GYmVpxQiN8ye7ke8=;20:OKCL0HE3IT+ZY8g0ezp+CsdzShnVRiop98yVgPCBnCRW9OtCpki24WnpwxDhTKhV7fKEX/nasb9boAdqQknTkQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB574; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:DM2PR03MB574;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB574; x-forefront-prvs: 0699FCD394 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(24454002)(189002)(13464003)(377454003)(164054003)(11100500001)(5001960100002)(62966003)(68736005)(2950100001)(86362001)(77096005)(66066001)(2900100001)(19580395003)(101416001)(122556002)(92566002)(77156002)(102836002)(40100003)(99286002)(74316001)(93886004)(19580405001)(106356001)(54356999)(105586002)(106116001)(64706001)(33656002)(189998001)(76176999)(87936001)(46102003)(81156007)(110136002)(4001540100001)(97736004)(50986999)(10400500002)(5001860100001)(76576001)(5007970100001)(5001830100001)(5003600100002)(5004730100002)(5002640100001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB574;H:DM2PR03MB574.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2015 06:51:36.9113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB574 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ARCH should have been ARM for this driver. Do you think this warning would go away if adding a dependency on ARM? Regards, Yuantian > -----Original Message----- > From: Fengguang Wu [mailto:fengguang.wu@intel.com] > Sent: Monday, September 14, 2015 12:05 PM > To: Tang Yuantian-B29983 > Cc: Tejun Heo ; hdegoede@redhat.com; linux- > ide@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings > > Yuantian, > > It's cross compiling on ARCH=openrisc. > > Thanks, > Fengguang > > On Mon, Sep 14, 2015 at 03:02:27AM +0000, Yuantian Tang wrote: > > Hello Tejun, > > > > The toolchain I used is: > > gcc version 4.8.3 20140401 (prerelease) (Linaro GCC 4.8-2014.04) > > > > I have not found this warning using this tool chain with -Wuninitialized flag. > > > > Regards, > > Yuantian > > > > > -----Original Message----- > > > From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo > > > Sent: Friday, September 11, 2015 9:55 PM > > > To: Tang Yuantian-B29983 > > > Cc: hdegoede@redhat.com; linux-ide@vger.kernel.org; linux- > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; Fengguang Wu > > > > > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable > > > warnings > > > > > > Hello, Yuantian. > > > > > > On Fri, Sep 11, 2015 at 05:27:25AM +0000, Yuantian Tang wrote: > > > > Hi Tejun, > > > > > > > > Could you please take the version 1 patch? > > > > The version 2 patch can't address these warnings, and the version > > > > 1 can > > > definitely remove them. > > > > In this case, that would cause any hidden bugs, so no worries. > > > > > > Ugh... I really hate changes which are made to just work around > > > compiler silliness. If this is something which goes away with newer > > > gcc, Fengguang can just make it as a known false positive. > > > Yuantian, which compiler are you using? > > > > > > Thanks. > > > > > > -- > > > tejun