From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754657AbcIJHuP (ORCPT ); Sat, 10 Sep 2016 03:50:15 -0400 Received: from mail-co1nam03on0112.outbound.protection.outlook.com ([104.47.40.112]:34406 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbcIJHuO (ORCPT ); Sat, 10 Sep 2016 03:50:14 -0400 From: Matthew Wilcox To: Christoph Hellwig , Dan Williams CC: Ross Zwisler , "Theodore Ts'o" , "linux-kernel@vger.kernel.org" , Andrew Morton , "linux-nvdimm@ml01.01.org" , Dave Chinner , "linux-mm@kvack.org" , "Andreas Dilger" , Alexander Viro , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" Subject: RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Thread-Topic: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Thread-Index: AQHR/YpUPtTm+Y/KNkaFWHessHWGb6BZUZEAgAJ1OgCAA8+SAIAAWGiAgBGKCACAADKkYIAALjKAgACWE4CAAAB1gA== Date: Sat, 10 Sep 2016 07:50:09 +0000 Message-ID: References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-3-ross.zwisler@linux.intel.com> <20160825075728.GA11235@infradead.org> <20160826212934.GA11265@linux.intel.com> <20160829074116.GA16491@infradead.org> <20160829125741.cdnbb2uaditcmnw2@thunk.org> <20160909164808.GC18554@linux.intel.com> <20160910073151.GB5295@infradead.org> In-Reply-To: <20160910073151.GB5295@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=mawilcox@microsoft.com; x-originating-ip: [108.161.120.18] x-ms-office365-filtering-correlation-id: 77ce7c7f-5618-4b0b-b851-08d3d94f1706 x-microsoft-exchange-diagnostics: 1;DM2PR21MB0092;6:34pt6CzbsAEfWFQFk8eqrzMkjWt/Ry2/61SmIVCEBj55yX7AmZuG6DYZOkzT/YFFBXYc6x4BM25K6OyZVVdmczIGSr8wOcVneoklN/LQ0MTIMIcSYHhDkDGRhWN0s3rPFMxWvjOMyzLfVismDO+FEN5julVtRBNbg9wjuaC3ZLA8qS7ErXSIZbsptMWpSijSPwwhD4pAUIbSwKpKEnxi3PnfZ4vs6StalHMkAZiRFecysslmPl7KokRIqjDpCNRpIU4AA2v/5RAvxMm3IikA8yYRHCDxz1qrYN8wZOc/9soOevPN+cSnplQ+6208+xrKYEfgIZivej0AZXD8tDugMA==;5:MApWCF3po98/J3BmlgbOfhInERep09kSFlg5PxNpc851h7f4BoPCYcYYJZTsD0rDCHCMbpvBXE+KE/ZoXsmrjPLdHIh0TaILDRhWRpeNGH0iarnTHSSAFy0vhUzPVyvwPOpI9mxgVdwhb8sfZRfaow==;24:6TJ6wuLe530KFRTYsTzK6ENakK0N8NR+sIq1KMbyl076G4oJH8+oKIt4shT8fkkdewjfxoP+auBOOz3SW84TY0fkuQkRrVqAl0VY5c0kM0g=;7:IXaMyY8vIr5kvJeX2GW939BKDEgmrvJKqodIR9G5//x3sEoGD9XL8pWe9BLOs623cH9o1kCnpJRx+agijSTrRy7qfYSaavaJy3E7mlBf/CLp9sRjmX5csvuhYBYFHvjC+V2M35Y9GVZZSivUac6ejzJWr17IMEWMtDSXCgd5ACHk5eQTpDQSZ+TQ8q5++1SIoX+RIn+2TrPwg0QicciZLXTov5JPBe+bO/f6Bu5omRr0crkOc1Fuyz5I8UlTahnT x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR21MB0092; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038);SRVR:DM2PR21MB0092;BCL:0;PCL:0;RULEID:;SRVR:DM2PR21MB0092; x-forefront-prvs: 0061C35778 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(189002)(24454002)(199003)(50986999)(6116002)(10290500002)(99286002)(189998001)(7416002)(9686002)(92566002)(586003)(10090500001)(122556002)(68736007)(2950100001)(74316002)(2900100001)(86362001)(3660700001)(101416001)(106116001)(5002640100001)(106356001)(8990500004)(5001770100001)(7736002)(19580395003)(105586002)(7846002)(5660300001)(7696004)(76576001)(86612001)(305945005)(3846002)(102836003)(97736004)(5005710100001)(54356999)(66066001)(11100500001)(10400500002)(19580405001)(76176999)(81166006)(77096005)(4326007)(2906002)(3280700002)(87936001)(8676002)(8936002)(33656002)(81156014)(93886004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR21MB0092;H:DM2PR21MB0089.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2016 07:50:10.0171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR21MB0092 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8A7oKDj005914 From: Christoph Hellwig [mailto:hch@infradead.org] > On Fri, Sep 09, 2016 at 03:34:43PM -0700, Dan Williams wrote: > > I agree with you that continuing to touch ext2 is not a good idea, but > > I'm not yet convinced that now is the time to go do dax-2.0 when we > > haven't finished shipping dax-1.0. > > I've mentioned this before, but I'd like to repeat it. With all the work reqwuired > in the file system I would prefer to drop DAX support in ext2 (and if people > really cry for it reinstate the trivial old xip support). That allegedly trivial old xip support was horrendously broken. And, er, it used an aop which you seem implacably opposed to in your earlier email. And that was truly a disgusting one from a layering point of view. Let me remind you: -       int (*get_xip_mem)(struct address_space *, pgoff_t, int, -                                               void **, unsigned long *); That void ** was an 'out' parameter to store a kernel address for the memory. The unsigned long * was also an 'out' parameter to store the PFN for the memory. The 'int' was actually a Boolean for whether to create or not, but you'd actually have to go look at the implementation to find that out; the documentation never said it. A real dog's breakfast of an API.