From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbcIJPzW (ORCPT ); Sat, 10 Sep 2016 11:55:22 -0400 Received: from mail-by2nam01on0092.outbound.protection.outlook.com ([104.47.34.92]:29792 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754249AbcIJPzU (ORCPT ); Sat, 10 Sep 2016 11:55:20 -0400 From: Matthew Wilcox To: Christoph Hellwig CC: Ross Zwisler , "Theodore Ts'o" , "linux-kernel@vger.kernel.org" , Andrew Morton , "linux-nvdimm@ml01.01.org" , Dave Chinner , "linux-mm@kvack.org" , "Andreas Dilger" , Alexander Viro , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" Subject: RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Thread-Topic: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Thread-Index: AQHR/YpUPtTm+Y/KNkaFWHessHWGb6BZUZEAgAJ1OgCAA8+SAIAAWGiAgBGKCACAADKkYIAAw88AgACGxwA= Date: Sat, 10 Sep 2016 15:55:17 +0000 Message-ID: References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-3-ross.zwisler@linux.intel.com> <20160825075728.GA11235@infradead.org> <20160826212934.GA11265@linux.intel.com> <20160829074116.GA16491@infradead.org> <20160829125741.cdnbb2uaditcmnw2@thunk.org> <20160909164808.GC18554@linux.intel.com> <20160910073012.GA5295@infradead.org> In-Reply-To: <20160910073012.GA5295@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=mawilcox@microsoft.com; x-originating-ip: [108.161.120.18] x-ms-office365-filtering-correlation-id: 28139596-0f1b-4973-da25-08d3d992dc6e x-microsoft-exchange-diagnostics: 1;DM2PR21MB0090;6:9aL7V+RsDFAVLMTCrn5VtvnFxFnVgDE+gciJXkCLm+AvOQPMEF0q4dxfWJFU6TGvZf++gnAqx8vvpnGeTA6JCp4Kr1vROBQFCKPTmwM9FAdh8bOfziJsxq4ybzHVXFekZRl182rZcj+kcYiMtkm3b2d2x9vwGNzGfJxgL5sZegycWeakSpNwoTuR1A/6+rKuuTemna1tHFJM8aSQcpt2015NtQbsKcR530skzg7cr77FmXDTIKmgEkEzMaDT7xLAhzea9eCpkj/422EoGfa68gUFuw7JtCIrKet4+oYSUwy5eYEVCjBVFwnxmsuqMYaedMAzax0GFN7oEWTXmFuaOQ==;5:DqWMOm492y470PUSa+RX/94XpdsIS5KmtZl/RjVTMA9Pr8fz+hk0o8Ci1WoptFJbodQKLG2sXCZXTtETTwLFulXHQBfQL+hHM20Ue+FKTLMDBobMdyMd/SBL+UKX8FHt792LkxJkGLWVSgXHYIIfiw==;24:fqVCyz0j3RjYrbg3TflwYzk6KJNzXkMes+i6/JGQxTtkQvEB8i8GoJy2jY3JOTUrmrB3Ww8mFn+ritgteNsEsvuTAjJ3oZXUWKZ5pOwpBRI=;7:wZwSkcmcMNhcww4LXhQ71PHLVfFDXsPvB/6Z0WZUhMk5MHf2ciHSaGy+mr2b9HEWV95nrMxD+HjTdZ1paqADIURW1PNHuM+5stlYhnNBFLHTaZZrcOsUfmgK9jPezoIfLWNHeOUwuvxU0RdaDWv5hKkuiX5hHdmmr3ZyO8HPbQk09VWSvsHzb9gbUsZ4atMwyAYOuGWg6QnqrglfSXzpt2qfoXdShHSfWpQpGkiXw7SyHSZEgguVi4jW0HNbKM6J x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR21MB0090; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038);SRVR:DM2PR21MB0090;BCL:0;PCL:0;RULEID:;SRVR:DM2PR21MB0090; x-forefront-prvs: 0061C35778 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(189002)(76576001)(9686002)(7696004)(66066001)(122556002)(7416002)(7736002)(7846002)(93886004)(2950100001)(2900100001)(106116001)(106356001)(99286002)(74316002)(305945005)(105586002)(8990500004)(86362001)(92566002)(81166006)(81156014)(8676002)(101416001)(10400500002)(10290500002)(87936001)(5005710100001)(77096005)(19580395003)(19580405001)(586003)(8936002)(3660700001)(97736004)(2906002)(50986999)(86612001)(33656002)(5002640100001)(5660300001)(3280700002)(68736007)(11100500001)(10090500001)(54356999)(76176999)(6116002)(3846002)(110136002)(102836003)(4326007)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR21MB0090;H:DM2PR21MB0089.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2016 15:55:17.3454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR21MB0090 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8AFtU1h006830 From: Christoph Hellwig [mailto:hch@infradead.org] > Either way we need to get rid of buffer_heads, and another aop that is entirely > caller specific is unaceptable. I finally figured out what you actually meant by this. You mean that instead of having an aop->populate_pfn, you want to define a populate_pfn_t callback and pass it in. Something like this: int ext2_populate_pfn(struct address_space *mapping, pgoff_t pgoff) { struct iomap iomap; ... return dax_populate_pfn(mapping, pgoff, &iomap); } int ext2_dax_fault(vma, vmf) { ... ret = dax_fault(vma, vmf, ext2_populate_pfn); ... } I don't have a problem with that. I'll work up something along those lines next week.