From: "Oleh Kuzhylnyi" <kuzhylol@gmail.com>
To: "Daniel Golle" <daniel@makrotopia.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] Input: hynitron-cst816x: time out gesture key release
Date: Mon, 12 Oct 2026 20:58:28 +0200 [thread overview]
Message-ID: <DM339BDR8JE2.1FJ5827JZIBWD@gmail.com> (raw)
In-Reply-To: <d73d26d8c9d75fa230e3dd64058acb65f45da64d.1791233147.git.daniel@makrotopia.org>
On Mon Oct 5, 2026 at 11:12 PM CEST, Daniel Golle wrote:
> The controller reports a gesture code once and can then stay quiet
> until the next touch, which leaves the gesture key pressed for as long
> as the panel is left alone. Release the gesture keys 40 ms after the
> last report that carried a gesture code, so that the release comes
> from whichever happens first, the timeout or a report without a
> gesture code. The 40 ms matches TSC200X_PENUP_TIME_MS, chosen there
> for the same want of a lift event from the controller, and has to stay
> above the interval between consecutive reports of a held gesture.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v4: follow the keycode lookup and the single read of patch 3
> v3: use timer_shutdown_sync() in the devres teardown action
> (Sashiko AI review)
> v2: skip the release when the interrupt handler re-armed the timer
> while the timer callback waited for the lock (Sashiko AI review)
>
> drivers/input/touchscreen/hynitron-cst816x.c | 52 ++++++++++++++++++--
> 1 file changed, 49 insertions(+), 3 deletions(-)
>
Tested on Raspberry Pi 4B with CST816S panel.
Reported coordinates and gestures are valid.
Thank you!
Tested-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>
Best regards,
Oleh Kuzhylnyi
next prev parent reply other threads:[~2026-10-12 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 21:10 [PATCH v4 0/5] Input: hynitron-cst816x: axes and gesture keys Daniel Golle
2026-10-05 21:11 ` [PATCH v4 1/5] dt-bindings: input: touchscreen: hynitron,cst816x: axes and panel Daniel Golle
2026-10-06 2:51 ` Rob Herring
2026-10-05 21:11 ` [PATCH v4 2/5] Input: hynitron-cst816x: respect touchscreen DT properties Daniel Golle
2026-10-05 21:11 ` [PATCH v4 3/5] Input: hynitron-cst816x: release gesture keys Daniel Golle
2026-10-12 18:57 ` Oleh Kuzhylnyi
2026-10-05 21:12 ` [PATCH v4 4/5] Input: hynitron-cst816x: time out gesture key release Daniel Golle
2026-10-12 18:58 ` Oleh Kuzhylnyi [this message]
2026-10-05 21:12 ` [PATCH v4 5/5] Input: hynitron-cst816x: set INPUT_PROP_DIRECT Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM339BDR8JE2.1FJ5827JZIBWD@gmail.com \
--to=kuzhylol@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®