From: "Gangurde, Abhijit" <abhijit.gangurde@amd.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Gupta, Nipun" <Nipun.Gupta@amd.com>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] cdx: call of_node_put() on error path
Date: Thu, 4 Jan 2024 09:06:34 +0000 [thread overview]
Message-ID: <DM4PR12MB7765E1280F2070228FE9D8BA8F67A@DM4PR12MB7765.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2e66efc4-a13a-4774-8c9d-763455fe4834@moroto.mountain>
[AMD Official Use Only - General]
> Add a missing call to of_node_put(np) on error.
>
> There was a second error path where "np" was NULL, but that situation is
> impossible. The for_each_compatible_node() loop iterator is always
> non-NULL. Just deleted that error path.
>
> Fixes: 54b406e10f03 ("cdx: Remove cdx controller list from cdx bus system")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Acked-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
Thanks,
Abhijit
prev parent reply other threads:[~2024-01-04 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 13:10 Dan Carpenter
2024-01-02 13:11 ` [PATCH v2 2/2] cdx: Unlock on error path in rescan_store() Dan Carpenter
2024-01-04 9:06 ` Gangurde, Abhijit
2024-01-04 9:06 ` Gangurde, Abhijit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB7765E1280F2070228FE9D8BA8F67A@DM4PR12MB7765.namprd12.prod.outlook.com \
--to=abhijit.gangurde@amd.com \
--cc=Nipun.Gupta@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®