From: Liu Changjie <liucj1228@outlook.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Luo Jie <jie.luo@oss.qualcomm.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: Add Maxio MAE0621A PHY
Date: Fri, 17 Jul 2026 17:26:42 +0800 [thread overview]
Message-ID: <DM4PR19MB6098A25EDB5602853E1EE44BACC62@DM4PR19MB6098.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20260717-immortal-moth-of-will-6ab571@quoll>
Hi Krzysztof,
> How did you address previous feedback?
>
> If you ignore feedback, shall we ignore the patch?
You are right. I should have documented the disposition of Andrew's
comment in this patch's changelog below the --- separator, rather than
only in the cover letter. Sorry about that.
Andrew suggested allowing a value of 0 to disable CLKOUT and noted that
this could also be added later. I intentionally did not add 0 in v2. The
only setting I have tested on this PHY is 125 MHz, and public documentation
for page 0xa43, register 0x19 is not available, so I cannot yet verify the
register programming and reset requirements for disabling CLKOUT.
Andrew's comment:
https://lore.kernel.org/r/1a02ef89-2608-44c4-847f-239d9b86c7ab@lunn.ch
The deferral is recorded in the cover letter's Changes in v2 section:
https://lore.kernel.org/r/MN0PR19MB609154F210DF84DCB29D3696ACC62@MN0PR19MB6091.namprd19.prod.outlook.com
I did not intend to ignore the feedback; I deferred that optional extension
until it can be documented and tested properly. I will state this explicitly
in the per-patch changelog in any future revision.
Best regards,
Liu Changjie
prev parent reply other threads:[~2026-07-17 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:39 [PATCH net-next v2 0/2] net: phy: Add Maxio MAE0621A support Liu Changjie
2026-07-17 3:44 ` [PATCH net-next v2 2/2] net: phy: Add support for the Maxio MAE0621A Liu Changjie
2026-07-17 15:15 ` Andrew Lunn
2026-07-17 3:44 ` [PATCH net-next v2 1/2] dt-bindings: net: Add Maxio MAE0621A PHY Liu Changjie
2026-07-17 9:05 ` Krzysztof Kozlowski
2026-07-17 9:26 ` Liu Changjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR19MB6098A25EDB5602853E1EE44BACC62@DM4PR19MB6098.namprd19.prod.outlook.com \
--to=liucj1228@outlook.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jie.luo@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox