From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: "Dave Hansen" <dave.hansen@intel.com>,
"Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>
Subject: RE: [PATCH v2 01/10] x86/Kconfig: enable X86_X2APIC by default and improve help text
Date: Thu, 3 Nov 2022 23:41:56 +0000 [thread overview]
Message-ID: <DM4PR84MB185539050D426BFA8EFAC36BAB389@DM4PR84MB1855.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <94f56ba4-2ee1-581b-36b9-98d59a978354@intel.com>
> -----Original Message-----
> From: Dave Hansen <dave.hansen@intel.com>
> Sent: Thursday, October 27, 2022 10:08 AM
...
> Subject: Re: [PATCH v2 01/10] x86/Kconfig: enable X86_X2APIC by default
> and improve help text
>
> On 10/27/22 07:45, Elliott, Robert (Servers) wrote:
> >> config X86_X2APIC
> >> - bool "Support x2apic"
> >> + bool "x2APIC interrupt controller architecture support"
> >> depends on X86_LOCAL_APIC && X86_64 && (IRQ_REMAP ||
> >> HYPERVISOR_GUEST)
> >> + default y
> > Could this option be added to
> > arch/x86/configs/x86_64_defconfig
> >
> > so defconfig builds don't crash on current platforms?
>
> Sounds reasonable. Care to send a patch?
How are the defconfig files supposed to keep up with valid
combinations of options?
arch/x86/Kconfig has this set of dependencies:
config X86_X2APIC
bool "Support x2apic"
depends on X86_LOCAL_APIC && X86_64 && (IRQ_REMAP || HYPERVISOR_GUEST)
config X86_LOCAL_APIC
def_bool y
depends on X86_64 || SMP || X86_32_NON_STANDARD || X86_UP_APIC || PCI_MSI
select IRQ_DOMAIN_HIERARCHY
select PCI_MSI_IRQ_DOMAIN if PCI_MSI
config X86_IO_APIC
def_bool y
depends on X86_LOCAL_APIC || X86_UP_IOAPIC
drivers/iommu/Kconfig has:
config IRQ_REMAP
bool "Support for Interrupt Remapping"
depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI
select DMAR_TABLE
Despite its filename, arch/x86/configs/x86_64_defconfig does not even have:
CONFIG_X86_64=y
which enables many options. That was added by:
commit 622e3f28e50f ("x86: 64-bit defconfig remake")
Sun May 4 19:57:19 2008 +0400
but removed by:
commit 8b1bb90701f9a51f ("defconfig reduction")
Sat Aug 14 22:05:58 2010 +0200
It does have
CONFIG_SMP=y
which should imply X86_LOCAL_APIC, but that's missing too.
It does have
CONFIG_HYPERVISOR_GUEST=y
so doesn't need IRQ_REMAP to enable X86_X2APIC.
next prev parent reply other threads:[~2022-11-03 23:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 8:47 [PATCH v2 00/10] x86: Kconfig cleanups and help text improvements Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 01/10] x86/Kconfig: enable X86_X2APIC by default and improve help text Mateusz Jończyk
2022-10-26 18:38 ` Borislav Petkov
2022-12-01 15:11 ` Thomas Gleixner
2022-10-27 14:45 ` Elliott, Robert (Servers)
2022-10-27 15:07 ` Dave Hansen
2022-11-03 23:41 ` Elliott, Robert (Servers) [this message]
2022-11-04 17:29 ` Dave Hansen
2024-02-02 14:08 ` David Heidelberg
2024-02-15 21:10 ` Mateusz Jończyk
2024-02-20 16:26 ` David Heidelberg
2024-07-05 22:28 ` David Heidelberg
2022-09-11 8:47 ` [PATCH v2 02/10] x86/apic: fix panic message when x2APIC is not supported Mateusz Jończyk
2022-10-27 15:08 ` Elliott, Robert (Servers)
2022-09-11 8:47 ` [PATCH v2 03/10] x86/Kconfig: always enable ARCH_SPARSEMEM_ENABLE Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 04/10] x86/Kconfig: drop X86_32_NON_STANDARD Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 05/10] x86/Kconfig: move all X86_EXTENDED_PLATFORM options together Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 06/10] x86/Kconfig: update lists in X86_EXTENDED_PLATFORM Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 07/10] x86/Kconfig: document CONFIG_PCI_MMCONFIG Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 08/10] x86/Kconfig: make CONFIG_PCI_CNB20LE_QUIRK depend on X86_32 Mateusz Jończyk
2022-09-13 22:50 ` Bjorn Helgaas
2022-09-11 8:47 ` [PATCH v2 09/10] x86/Kconfig: document release year of glibc 2.3.3 Mateusz Jończyk
2022-09-11 8:47 ` [PATCH v2 10/10] x86/Kconfig: remove CONFIG_ISA_BUS Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR84MB185539050D426BFA8EFAC36BAB389@DM4PR84MB1855.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®