From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Conor Dooley <conor@kernel.org>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"jszhang@kernel.org" <jszhang@kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] dt-bindings: mmc: snps,dwcmshc-sdhci: add HPE GSC dwcmshc compatible
Date: Tue, 3 Mar 2026 14:36:27 +0000 [thread overview]
Message-ID: <DM4PR84MB1927565588A5B529020C4A80887FA@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20260302-denture-widow-dfe7fa5ef561@spud>
Hi Conor,
> > + mmc@c0100000 {
> > + compatible = "hpe,gsc-dwcmshc";
> > + reg = <0xc0100000 0x1000>, <0xc0000110 0x4>;
> A 0x4 sized region is always incredibly suspect. What is at address
> 0xc000010c or 0xc0000114? Usually in these sorts of scenarios, it ends
> up being that there's some sort of misc. register region of which this
> is just one register, that should be represented as a syscon.
The first register set will be the actual device / IP we are working with.
The second is as you suggested is just a misc register region.
I will work on handling that for the second revision of the patch series.
Thank you,
-Nick
next prev parent reply other threads:[~2026-03-03 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 19:01 [PATCH v1 0/2] mmc: sdhci-of-dwcmshc: Add HPE GSC eMMC support nick.hawkins
2026-03-02 19:01 ` [PATCH v1 1/2] dt-bindings: mmc: snps,dwcmshc-sdhci: add HPE GSC dwcmshc compatible nick.hawkins
2026-03-02 19:47 ` Conor Dooley
2026-03-03 14:36 ` Hawkins, Nick [this message]
2026-03-02 19:01 ` [PATCH v1 2/2] mmc: sdhci-of-dwcmshc: Add HPE GSC eMMC support nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR84MB1927565588A5B529020C4A80887FA@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM \
--to=nick.hawkins@hpe.com \
--cc=adrian.hunter@intel.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®