mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "Daniel Lezcano" <daniel.lezcano@oss.qualcomm.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Kurt Borja" <kuurtb@gmail.com>
Cc: <sre@kernel.org>, <bryan.odonoghue@linaro.org>,
	<platform-driver-x86@vger.kernel.org>,
	"LKML" <linux-kernel@vger.kernel.org>,
	<stephan.gerhold@linaro.org>
Subject: Re: [RFC PATCH] platform/arm64: lenovo-thinkpad-t14s: Adjust thermal trip with platform profile
Date: Thu, 15 Oct 2026 02:08:41 -0300	[thread overview]
Message-ID: <DM55HM3TYCHT.1F7FX19ORJPG@gmail.com> (raw)
In-Reply-To: <36418d4e-ba34-4c31-b676-1e636cfb8a7a@oss.qualcomm.com>

On Wed Oct 14, 2026 at 10:03 AM -03, Daniel Lezcano wrote:
> On 10/14/26 12:19, Ilpo Järvinen wrote:
>> + more people.

Hi all,

>> 
>> On Thu, 1 Oct 2026, Daniel Lezcano wrote:
>> 
>>> Tie the keyboard thermal mitigation temperature to the platform profile
>>> selected through the ThinkPad embedded controller.
>>>
>>> The EC reports Fn+L, Fn+M and Fn+H events corresponding to low-power,
>>> balanced and performance operating modes. Use these events to update the
>>> passive trip point of the "keyboard-thermal" zone to 49.85°C, 57.85°C
>>> and 59.85°C respectively.
>>>
>>> These thresholds match the thermal mitigation temperatures used by the
>>> platform for the corresponding operating profiles.
>>>
>>> Look up the keyboard thermal zone at probe time and locate the passive
>>> trip named "keyboard-ec-alert". The trip name is used deliberately so
>>> the EC driver can identify the device-tree trip associated with the
>>> platform thermal profile without depending on its position in the trip
>>> table.
>>>
>>> Initialize the thermal mitigation threshold to the balanced profile,
>>> matching the default platform behaviour, and update the thermal zone
>>> whenever a profile change event is reported by the EC so that the new
>>> mitigation temperature takes effect immediately.
>>>
>>> Using the platform_profile API would provide a more appropriate interface
>>> for exposing and managing these operating modes. However, while the API
>>> itself is generic, the platform profile core implementation currently
>>> lives under the ACPI framework. Making it available to device-tree based
>>> platforms requires separating the generic infrastructure from ACPI,
>>> which is a larger and independent piece of work.
>> 
>> So the only problem is that platform profile resides underneath acpi
>> namespace in sysfs?
>
> Yes but I have a series I'm about to send decoupling the 
> platform_profile from ACPI

The platform-profile already has a platform agnostic interface at
/sys/class/platform-profile-N. Unless I'm missing something, I believe
that interface should already cover your use case and its also the
recommended way to expose interfaces to user-space.

I was not around here when this functionality was exposed to
/sys/firmware/acpi so I don't really know the context, but I personally
don't see a reason to duplicate this at /sys/firmware/devicetree or
something like that.

-- 
Thanks,
 ~ Kurt

  parent reply	other threads:[~2026-10-15  5:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 18:19 Daniel Lezcano
2026-10-14 10:19 ` Ilpo Järvinen
2026-10-14 12:46   ` Hans de Goede
2026-10-14 13:03   ` Daniel Lezcano
2026-10-14 13:10     ` Hans de Goede
2026-10-15  5:08     ` Kurt Borja [this message]
2026-10-15  7:10       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM55HM3TYCHT.1F7FX19ORJPG@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=daniel.lezcano@oss.qualcomm.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sre@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®