mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Appana Durga Kedareswara Rao <appanad@xilinx.com>
To: Radhey Shyam Pandey <radheys@xilinx.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	Michal Simek <michals@xilinx.com>,
	Radhey Shyam Pandey <radheys@xilinx.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/4] dmaengine: xilinx_dma: Introduce helper macro for preparing dma address
Date: Fri, 19 Oct 2018 10:37:11 +0000	[thread overview]
Message-ID: <DM5PR02MB21878ECD3C2B2E4535F2244FDCF90@DM5PR02MB2187.namprd02.prod.outlook.com> (raw)
In-Reply-To: <1538241480-13844-4-git-send-email-radhey.shyam.pandey@xilinx.com>

Hi,

	Thanks for the patch...

> 
> This patch introduces the xilinx_prep_dma_addr_t macro which prepares
> dma_addr_t from hardware buffer descriptor LSB and MSB fields. It will be
> used in simple dma 64-bit programming sequence.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>

Reviewed-by: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>

Regards,
Kedar.

> ---
> Changes for v2:
> New patch- Preparatory change for 4/4 fix.
> ---
>  drivers/dma/xilinx/xilinx_dma.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index a37871e..c27ab64 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -190,6 +190,8 @@
>  /* AXI CDMA Specific Masks */
>  #define XILINX_CDMA_CR_SGMODE          BIT(3)
> 
> +#define xilinx_prep_dma_addr_t(addr)	\
> +	((dma_addr_t)((u64)addr##_##msb << 32 | (addr)))
>  /**
>   * struct xilinx_vdma_desc_hw - Hardware Descriptor
>   * @next_desc: Next Descriptor Pointer @0x00
> --
> 1.7.1


  reply	other threads:[~2018-10-19 10:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29 17:17 [PATCH v2 0/4] dmaengine: xilinx_dma: Minor fix and refactoring Radhey Shyam Pandey
2018-09-29 17:17 ` [PATCH v2 1/4] dmaengine: xilinx_dma: Refactor axidma channel allocation Radhey Shyam Pandey
2018-09-29 17:17 ` [PATCH v2 2/4] dmaengine: xilinx_dma: Refactor axidma channel validation Radhey Shyam Pandey
2018-11-11 10:29   ` Vinod Koul
2018-11-15  2:57     ` Radhey Shyam Pandey
2018-09-29 17:17 ` [PATCH v2 3/4] dmaengine: xilinx_dma: Introduce helper macro for preparing dma address Radhey Shyam Pandey
2018-10-19 10:37   ` Appana Durga Kedareswara Rao [this message]
2018-09-29 17:18 ` [PATCH v2 4/4] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer Radhey Shyam Pandey
2018-10-19 10:38   ` Appana Durga Kedareswara Rao
2018-11-11 10:34 ` [PATCH v2 0/4] dmaengine: xilinx_dma: Minor fix and refactoring Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR02MB21878ECD3C2B2E4535F2244FDCF90@DM5PR02MB2187.namprd02.prod.outlook.com \
    --to=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michals@xilinx.com \
    --cc=radheys@xilinx.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®