From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbdI0M7D (ORCPT ); Wed, 27 Sep 2017 08:59:03 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:53074 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbdI0M66 (ORCPT ); Wed, 27 Sep 2017 08:58:58 -0400 X-IronPort-AV: E=Sophos;i="5.42,445,1500912000"; d="scan'208";a="54544752" From: Avri Altman To: Linus Walleij , Adrian Hunter CC: Ulf Hansson , linux-mmc , linux-block , linux-kernel , Bough Chen , Alex Lemberg , Mateusz Nowak , Yuliy Izrailov , Jaehoon Chung , Dong Aisheng , Das Asutosh , Zhangfei Gao , Sahitya Tummala , Harjani Ritesh , Venu Byravarasu , Shawn Lin , Christoph Hellwig Subject: RE: [PATCH V9 09/15] mmc: core: Add parameter use_blk_mq Thread-Topic: [PATCH V9 09/15] mmc: core: Add parameter use_blk_mq Thread-Index: AQHTNyEio2jEgOu0EkqKBMg/zBaIEKLIsj2Q Date: Wed, 27 Sep 2017 12:58:53 +0000 Message-ID: References: <1506083824-4024-1-git-send-email-adrian.hunter@intel.com> <1506083824-4024-10-git-send-email-adrian.hunter@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1241;20:RKopuzctHCljZ4XLy/R89/jc1ZMsuj55esSEEFg7SAy2NkaIamBRp6P+3jUwXSwWRhrJ5unZdq9GUS48qk8+Xz6LLqUxkqg0wDHYtrbvyLXD6Bpm+Z47qMoWJsU+13F3ciEQwdqZ+m5CLdGs3ctBS5WERQPIGIRjClc8Pd1bEh4= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 53dfe2d0-9e9f-4d9a-c146-08d505a781a9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1241; x-ms-traffictypediagnostic: CY1PR0401MB1241: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(7411616537696)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1241;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1241; x-forefront-prvs: 04433051BF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(346002)(376002)(199003)(189002)(13464003)(24454002)(377454003)(86362001)(25786009)(106356001)(105586002)(97736004)(53546010)(6306002)(72206003)(8936002)(81156014)(81166006)(229853002)(7416002)(102836003)(5660300001)(54906003)(99286003)(74316002)(9686003)(53936002)(8656003)(7736002)(6116002)(55016002)(3846002)(316002)(966005)(110136005)(54356999)(76176999)(6506006)(2900100001)(101416001)(189998001)(8676002)(7696004)(14454004)(3280700002)(2950100002)(6246003)(3660700001)(77096006)(39060400002)(305945005)(6436002)(33656002)(2906002)(68736007)(66066001)(478600001)(50986999)(4326008)(422495003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1241;H:DM5PR04MB1085.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2017 12:58:53.4450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1241 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8RCx60O019757 > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Linus Walleij > Sent: Wednesday, September 27, 2017 2:42 AM > To: Adrian Hunter > Cc: Ulf Hansson ; linux-mmc mmc@vger.kernel.org>; linux-block ; linux- > kernel ; Bough Chen ; > Alex Lemberg ; Mateusz Nowak > ; Yuliy Izrailov ; > Jaehoon Chung ; Dong Aisheng > ; Das Asutosh ; Zhangfei > Gao ; Sahitya Tummala > ; Harjani Ritesh ; > Venu Byravarasu ; Shawn Lin chips.com>; Christoph Hellwig > Subject: Re: [PATCH V9 09/15] mmc: core: Add parameter use_blk_mq > > On Fri, Sep 22, 2017 at 2:36 PM, Adrian Hunter > wrote: > > > Until mmc has blk-mq support fully implemented and tested, add a > > parameter use_blk_mq, default to false unless config option > > MMC_MQ_DEFAULT is selected. > > > > Signed-off-by: Adrian Hunter > > > +config MMC_MQ_DEFAULT > > + bool "MMC: use blk-mq I/O path by default" > > + depends on MMC && BLOCK > > I would say: > default y > > Why not. SCSI is starting to enable this by default so IMO we should not take > the intermediate step of having this as optional. Otherwise it never gets > tested. > > Set it to default y and after two kernel releases, if nothing happens, we simply > delete the old block layer path. > > > +#ifdef CONFIG_MMC_MQ_DEFAULT > > +bool mmc_use_blk_mq = true; > > +#else > > +bool mmc_use_blk_mq = false; > > +#endif > > +module_param_named(use_blk_mq, mmc_use_blk_mq, bool, S_IWUSR | > > +S_IRUGO); > > Are people really modprobing this so it needs to be a module parameter? Module param can be changed in runtime > > Maybe I'm the only developer stupid enough to just recompile and reboot the > whole kernel, I guess this makes sense if you're testing on the same machine > you're developing on (no cross-compilation and remote target) which I guess > is what some Intel people are doing with their laptops. > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the > body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html