From: Prabhakar Kushwaha <pkushwaha@marvell.com>
To: "yury.norov@gmail.com" <yury.norov@gmail.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mirq-linux@rere.qmqm.pl" <mirq-linux@rere.qmqm.pl>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"David.Laight@aculab.com" <David.Laight@aculab.com>,
"joe@perches.com" <joe@perches.com>,
"dennis@kernel.org" <dennis@kernel.org>,
"kernel@esmil.dk" <kernel@esmil.dk>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"matti.vaittinen@fi.rohmeurope.com"
<matti.vaittinen@fi.rohmeurope.com>,
"aklimov@redhat.com" <aklimov@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alok Prasad <palok@marvell.com>
Subject: RE: [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in qed_roce_stop()
Date: Tue, 15 Feb 2022 05:35:06 +0000 [thread overview]
Message-ID: <DM5PR1801MB205732C84AFB0449EC342B6DB2349@DM5PR1801MB2057.namprd18.prod.outlook.com> (raw)
Hi Yury,
> -----Original Message-----
> From: Prabhakar Kushwaha <pkushwaha@marvell.com>
> Sent: Tuesday, February 15, 2022 10:41 AM
> To: Prabhakar Kushwaha <pkushwaha@marvell.com>
> Subject: [PATCH 11/49] qed: replace bitmap_weight with
> bitmap_empty in qed_roce_stop()
>
> Subject: [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in
> qed_roce_stop()
> Date: Thu, 10 Feb 2022 14:48:55 -0800
> From: Yury Norov mailto:yury.norov@gmail.com
> To: Yury Norov mailto:yury.norov@gmail.com, Andy Shevchenko
> mailto:andriy.shevchenko@linux.intel.com, Rasmus Villemoes
> mailto:linux@rasmusvillemoes.dk, Andrew Morton mailto:akpm@linux-
> foundation.org, Michał Mirosław mailto:mirq-linux@rere.qmqm.pl, Greg Kroah-
> Hartman mailto:gregkh@linuxfoundation.org, Peter Zijlstra
> mailto:peterz@infradead.org, David Laight mailto:David.Laight@aculab.com,
> Joe Perches mailto:joe@perches.com, Dennis Zhou mailto:dennis@kernel.org,
> Emil Renner Berthing mailto:kernel@esmil.dk, Nicholas Piggin
> mailto:npiggin@gmail.com, Matti Vaittinen
> mailto:matti.vaittinen@fi.rohmeurope.com, Alexey Klimov
> mailto:aklimov@redhat.com, mailto:linux-kernel@vger.kernel.org, Ariel Elior
> mailto:aelior@marvell.com, Manish Chopra mailto:manishc@marvell.com,
> David S. Miller mailto:davem@davemloft.net, Jakub Kicinski
> mailto:kuba@kernel.org, mailto:netdev@vger.kernel.org
>
>
> qed_roce_stop() calls bitmap_weight() to check if any bit of a given
> bitmap is set. We can do it more efficiently with bitmap_empty() because
> bitmap_empty() stops traversing the bitmap as soon as it finds first set
> bit, while bitmap_weight() counts all bits unconditionally.
>
> Signed-off-by: Yury Norov mailto:yury.norov@gmail.com
> ---
Acked-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
next reply other threads:[~2022-02-15 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 5:35 Prabhakar Kushwaha [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-10 22:48 [PATCH v4 00/49] bitmap: optimize bitmap_weight() usage Yury Norov
2022-02-10 22:48 ` [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in qed_roce_stop() Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1801MB205732C84AFB0449EC342B6DB2349@DM5PR1801MB2057.namprd18.prod.outlook.com \
--to=pkushwaha@marvell.com \
--cc=David.Laight@aculab.com \
--cc=aelior@marvell.com \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dennis@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel@esmil.dk \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=manishc@marvell.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=palok@marvell.com \
--cc=peterz@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®