From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3997182-1516722205-2-17983509240302032553 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516722204; b=fXxv5r/fvKjN29YBtFvjseiaxqRvtf+a7ZobQB3mpE9BKLa VyO4dD3RRp2NpX8A9KpTo88wuMbgdKKcrejvSfyDXKTkF6+102Hs/QzwkP8N/nSc FcH3XCF3x4xuXXvhhA2djtu2pVN2cl/r+l9l/6D9Pqesa3bYPIw/dUc6x7ftxqRF nV8w6QeoR80KEc/pDHJm0zBGOjlpaRcPQzwUVbnZWsdANZd5PAknil59PTzX0fE4 MFBzVrk0vaQ2ElijB4p9OccyJZrj86Qpx1kULU0+70DnIGKnTl8kvJgNbKSxyPn7 7IlH169f1WRKslfVamNfF/09p6hMcnqD5aS+fYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :references:in-reply-to:mime-version:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516722204; bh=t wKiglgZDsks8o1m6x1AqBdpgmTOXRtSRTgbZ0E1bdw=; b=PFyzzqoOgRBHAKQgV RXVI3EC8rinUW+LOBPFc6TYYjerri3umqws1pFPI/z1VAvWIgJCuV5PSZiFsBdWR flewavxJ4rc5yqhdniT5jd5VknSyeJ4KzSjI/DZS2GztTCk8dbT7WPAFmNJSoNJg /pPR0H61N78+cXGcphWX3ujjKxz0VrL5IVnEk5Uaf2JTYc1xpNDPHizxyDBF+u03 iGkHwaqTxU5ZMzJcWi9xqa2o6H/SZgo3AiY5vaVClbsmOYXV3+A8plmcUdWCL7A8 SoHk1hv6kuMjVk6YGvgyOG/wc4dcQBtc4iYr+m8ipntpNyRfYPT2BGeIe5l4Yd8+ tI0lQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=f7VW3fzc x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=fail (p=reject,has-list-id=yes,d=reject) header.from=microsoft.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=f7VW3fzc x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=fail (p=reject,has-list-id=yes,d=reject) header.from=microsoft.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org From: Haiyang Zhang To: Mohammed Gamal , "netdev@vger.kernel.org" Subject: RE: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 hosts Thread-Topic: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 hosts Thread-Index: AQHTlC1e8Zik2Qtg9U24YPQnRmfoY6OBmUDA Date: Tue, 23 Jan 2018 15:43:13 +0000 Message-ID: References: <1516700045-32142-1-git-send-email-mgamal@redhat.com> In-Reply-To: <1516700045-32142-1-git-send-email-mgamal@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haiyangz@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-01-23T15:43:10.8752251Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [69.130.166.81] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1096; 7:qmzZDISGgd7tfuaL4pPeIfwQxVryPOtoNmGwoHOb9C5rALWWxmu3+g8aMpp72S2FnLCDGWB+7U73JS+2TAFv/jXjb11gyCqieqE2zM95u5qLSGJAidjVQHS5UDjkh+Hw9bnMKA+NHPLKr+IwWGzt6g9xGTTEq5cWfcMD8+WCaRVnAECT0H6n6+2QQs2ffk8XR0e4ZOWscEQXnuDwuztqyHwsbOeP2Vaq2hP0ZEfuFK7wz2PJJ8J6QxCWoTRxMn4q x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 43f64320-a97b-4213-689c-08d562780362 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020); SRVR:DM5PR2101MB1096; x-ms-traffictypediagnostic: DM5PR2101MB1096: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231046)(2400081)(944501161)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1096; BCL:0; PCL:0; RULEID:(100000803126)(100110400120); SRVR:DM5PR2101MB1096; x-forefront-prvs: 05610E64EE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(346002)(39380400002)(366004)(13464003)(199004)(189003)(6436002)(33656002)(9686003)(55016002)(54906003)(25786009)(2950100002)(86612001)(4326008)(59450400001)(6116002)(53546011)(110136005)(316002)(106356001)(8936002)(10290500003)(7736002)(81166006)(8676002)(26005)(6346003)(3846002)(305945005)(229853002)(102836004)(81156014)(6506007)(478600001)(97736004)(22452003)(2900100001)(76176011)(2501003)(5660300001)(14454004)(3280700002)(8990500004)(3660700001)(6246003)(53936002)(10090500001)(74316002)(86362001)(105586002)(7696005)(68736007)(99286004)(66066001)(2906002)(345774005)(5250100002)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1096; H:DM5PR2101MB0871.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=haiyangz@microsoft.com; x-microsoft-antispam-message-info: /IzGiK4AWr93COaM7KAT5kKAetxPd0aI0Kjlkd2a5R5QITTBSIl+PiHss/qUVNiTO2oqaZU47lCRkMcYjjmNJQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43f64320-a97b-4213-689c-08d562780362 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2018 15:43:13.3450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1096 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "otubo@redhat.com" , Stephen Hemminger , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "vkuznets@redhat.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > -----Original Message----- > From: Mohammed Gamal [mailto:mgamal@redhat.com] > Sent: Tuesday, January 23, 2018 4:34 AM > To: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang ; > Stephen Hemminger ; vkuznets@redhat.com; > cavery@redhat.com; otubo@redhat.com; Mohammed Gamal > > Subject: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 > hosts > > Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") > introduced a regression that caused VMs not to shutdown after > netvsc_device_remove() is called. This is caused by GPADL teardown > sequence change, and while that was necessary to fix issues with Win2016 > hosts, it did introduce a regression for earlier versions. > > Prior to commit 0cf737808 the call sequence in netvsc_device_remove() was > as follows (as implemented in netvsc_destroy_buf()): > 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message > 2- Teardown receive buffer GPADL > 3- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF message > 4- Teardown send buffer GPADL > 5- Close vmbus > > This didn't work for WS2016 hosts. Commit 0cf737808 split > netvsc_destroy_buf() into two functions and rearranged the order as follows > 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message > 2- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF message > 3- Close vmbus > 4- Teardown receive buffer GPADL > 5- Teardown send buffer GPADL > > That worked well for WS2016 hosts, but for WS2012 hosts it prevented VMs > from shutting down. > > This patch series works around this problem. The first patch splits > netvsc_revoke_buf() and netvsc_teardown_gpadl() into two finer grained > functions for tearing down send and receive buffers individally. The second > patch uses the finer grained functions to implement the teardown sequence > according to the host's version. We keep the behavior introduced in > 0cf737808ae7 for Windows > 2016 hosts, while we re-introduce the old sequence for earlier verions. > > Mohammed Gamal (2): > hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl() > hv_netvsc: Change GPADL teardown order according to Hyper-V version > > drivers/net/hyperv/netvsc.c | 50 > +++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 42 insertions(+), 8 deletions(-) Thank you for the patches. We are testing them internally. - Haiyang _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel