From: Radhey Shyam Pandey <radheys@xilinx.com>
To: Joe Perches <joe@perches.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
Michal Simek <michals@xilinx.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/5] net: emaclite: Balance braces in else statement
Date: Tue, 19 Jun 2018 05:42:11 +0000 [thread overview]
Message-ID: <DM6PR02MB436134273D962B3FF3242723C7700@DM6PR02MB4361.namprd02.prod.outlook.com> (raw)
In-Reply-To: <644296b273a76469baf641dd712c7a5451cd34fe.camel@perches.com>
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Monday, June 18, 2018 9:33 PM
> To: Radhey Shyam Pandey <radheys@xilinx.com>; davem@davemloft.net;
> andrew@lunn.ch; Michal Simek <michals@xilinx.com>
> Cc: netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 2/5] net: emaclite: Balance braces in else statement
>
> On Mon, 2018-06-18 at 17:20 +0530, Radhey Shyam Pandey wrote:
> > Remove else as it is not required with if doing a return.
> > Fixes below checkpatch warning.
>
> > WARNING: else is not generally useful after a break or return
>
> checkpatch is stupid and doesn't understand code flow.
> Always try to improve code flow instead of merely
> following brainless instructions from a script.
>
> So:
>
> > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> []
> > @@ -569,13 +569,11 @@ static void xemaclite_tx_handler(struct net_device
> *dev)
> > (u8 *) lp->deferred_skb->data,
> > lp->deferred_skb->len) != 0)
> > return;
> > - else {
> > - dev->stats.tx_bytes += lp->deferred_skb->len;
> > - dev_kfree_skb_irq(lp->deferred_skb);
> > - lp->deferred_skb = NULL;
> > - netif_trans_update(dev); /* prevent tx timeout */
> > - netif_wake_queue(dev);
> > - }
> > + dev->stats.tx_bytes += lp->deferred_skb->len;
> > + dev_kfree_skb_irq(lp->deferred_skb);
> > + lp->deferred_skb = NULL;
> > + netif_trans_update(dev); /* prevent tx timeout */
> > + netif_wake_queue(dev);
> > }
> > }
>
> If you really want to redo this function, perhaps something like:
Thanks for the review. Yes, In v2 I will refactor the code to have
failure path return early.
>
> static void xemaclite_tx_handler(struct net_device *dev)
> {
> struct net_local *lp = netdev_priv(dev);
>
> dev->stats.tx_packets++;
>
> if (!lp->deferred_skb)
> return;
>
> if (xemaclite_send_data(lp, (u8 *)lp->deferred_skb->data,
> lp->deferred_skb->len))
> return;
>
> dev->stats.tx_bytes += lp->deferred_skb->len;
> dev_kfree_skb_irq(lp->deferred_skb);
> lp->deferred_skb = NULL;
> netif_trans_update(dev); /* prevent tx timeout */
> netif_wake_queue(dev);
> }
>
> > @@ -1052,13 +1050,13 @@ static bool get_bool(struct platform_device
> *ofdev, const char *s)
> > {
> > u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL);
> >
> > - if (p) {
> > + if (p)
> > return (bool)*p;
> > - } else {
> > - dev_warn(&ofdev->dev, "Parameter %s not found,"
> > +
> > + dev_warn(&ofdev->dev, "Parameter %s not found,"
> > "defaulting to false\n", s);
> > - return false;
> > - }
> > +
> > + return false;
> > }
>
> And this function has backward logic as the failure paths
> are the ones that should return early or use a goto.
>
> Perhaps something like:
Yes, will change it.
>
> static bool get_bool(struct platform_device *ofdev, const char *s)
> {
> u32 *p = (u32 *)of_get_property(ofdev->dev.of_node, s, NULL);
>
> if (!p) {
> dev_warn(&ofdev->dev,
> "Parameter '%s' not found, defaulting to false\n", s);
> return false;
> }
>
> return *p;
> }
next prev parent reply other threads:[~2018-06-19 5:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 11:50 [PATCH 0/5] Fixes coding style in xilinx_emaclite.c Radhey Shyam Pandey
2018-06-18 11:50 ` [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name Radhey Shyam Pandey
2018-06-18 11:50 ` [PATCH 2/5] net: emaclite: Balance braces in else statement Radhey Shyam Pandey
2018-06-18 16:03 ` Joe Perches
2018-06-19 5:42 ` Radhey Shyam Pandey [this message]
2018-06-18 11:50 ` [PATCH 3/5] net: emaclite: update kernel-doc comments Radhey Shyam Pandey
2018-06-18 11:50 ` [PATCH 4/5] net: emaclite: Fix block comments style Radhey Shyam Pandey
2018-06-18 11:50 ` [PATCH 5/5] net: emaclite: Remove unnecessary spaces Radhey Shyam Pandey
2018-06-19 22:55 ` [PATCH 0/5] Fixes coding style in xilinx_emaclite.c David Miller
-- strict thread matches above, loose matches on Subject: below --
2018-06-18 11:08 Radhey Shyam Pandey
2018-06-18 11:08 ` [PATCH 2/5] net: emaclite: Balance braces in else statement Radhey Shyam Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB436134273D962B3FF3242723C7700@DM6PR02MB4361.namprd02.prod.outlook.com \
--to=radheys@xilinx.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®