From: "Nassiri, Mohammad" <mnassiri@ciena.com>
To: Dmitry Safonov <dima@arista.com>, Shuah Khan <shuah@kernel.org>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Salam Noureddine <noureddine@arista.com>,
Bob Gilligan <gilligan@arista.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>
Subject: RE: [PATCH 12/12] selftests/net: Add TCP-AO key-management test
Date: Fri, 12 Jan 2024 18:57:36 +0000 [thread overview]
Message-ID: <DM6PR04MB4202DA43D14985A28055CE0FC56F2@DM6PR04MB4202.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20231215-tcp-ao-selftests-v1-12-f6c08180b985@arista.com>
>-----Original Message-----
>From: Dmitry Safonov <dima@arista.com>
>Sent: Thursday, December 14, 2023 9:36 PM
>+
>+static void end_server(const char *tst_name, int sk,
>+ struct tcp_ao_counters *begin) {
>+ struct tcp_ao_counters end;
>+
>+ if (test_get_tcp_ao_counters(sk, &end))
>+ test_error("test_get_tcp_ao_counters()");
>+ verify_keys(tst_name, sk, false, true);
>+
>+ synchronize_threads(); /* 4: verified => closed */
>+ close(sk);
>+
>+ verify_counters(tst_name, true, false, begin, &end);
Shouldn't it be reversed instead?
verify_counters(tst_name, false, true, begin, &end);
The sk is an accept socket and the function is called by the server.
>+ synchronize_threads(); /* 5: counters */ }
>+
>+int main(int argc, char *argv[])
>+{
>+ test_init(120, server_fn, client_fn);
>+ return 0;
>+}
>
>--
>2.43.0
next prev parent reply other threads:[~2024-01-12 18:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:36 [PATCH 00/12] selftests/net: Add TCP-AO tests Dmitry Safonov
2023-12-15 2:36 ` [PATCH 01/12] selftests/net: Add TCP-AO library Dmitry Safonov
2024-01-12 18:02 ` Nassiri, Mohammad
2023-12-15 2:36 ` [PATCH 02/12] selftests/net: Verify that TCP-AO complies with ignoring ICMPs Dmitry Safonov
2023-12-18 9:03 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 03/12] selftests/net: Add TCP-AO ICMPs accept test Dmitry Safonov
2023-12-18 9:04 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 04/12] selftests/net: Add a test for TCP-AO keys matching Dmitry Safonov
2023-12-18 9:05 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 05/12] selftests/net: Add test for TCP-AO add setsockopt() command Dmitry Safonov
2023-12-18 9:06 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 06/12] selftests/net: Add TCP-AO + TCP-MD5 + no sign listen socket tests Dmitry Safonov
2023-12-18 9:08 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 07/12] selftests/net: Add test/benchmark for removing MKTs Dmitry Safonov
2023-12-18 9:09 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 08/12] selftests/net: Add TCP_REPAIR TCP-AO tests Dmitry Safonov
2023-12-18 9:10 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 09/12] selftests/net: Add SEQ number extension test Dmitry Safonov
2023-12-18 9:11 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 10/12] selftests/net: Add TCP-AO RST test Dmitry Safonov
2023-12-18 9:11 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 11/12] selftests/net: Add TCP-AO selfconnect/simultaneous connect test Dmitry Safonov
2023-12-18 9:12 ` Hangbin Liu
2023-12-15 2:36 ` [PATCH 12/12] selftests/net: Add TCP-AO key-management test Dmitry Safonov
2024-01-12 18:57 ` Nassiri, Mohammad [this message]
2024-01-15 18:05 ` Dmitry Safonov
2024-01-15 22:26 ` Nassiri, Mohammad
2023-12-18 9:36 ` [PATCH 00/12] selftests/net: Add TCP-AO tests Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB4202DA43D14985A28055CE0FC56F2@DM6PR04MB4202.namprd04.prod.outlook.com \
--to=mnassiri@ciena.com \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gilligan@arista.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®