mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Bart Van Assche <bvanassche@acm.org>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	Zang Leigang <zangleigang@hisilicon.com>,
	Avi Shchislowski <Avi.Shchislowski@wdc.com>,
	Bean Huo <beanhuo@micron.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: [PATCH v4 6/9] scsi: ufshpb: Add hpb dev reset response
Date: Tue, 2 Mar 2021 09:32:42 +0000	[thread overview]
Message-ID: <DM6PR04MB65752B178AD8CC166D165882FC999@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <2038148563.21614673682593.JavaMail.epsvc@epcpadp4>

> 
> Hi Avri,
> 
> > diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> > index cf704b82e72a..f33aa28e0a0a 100644
> > --- a/drivers/scsi/ufs/ufshpb.c
> > +++ b/drivers/scsi/ufs/ufshpb.c
> > @@ -642,7 +642,8 @@ int ufshpb_prep(struct ufs_hba *hba, struct
> ufshcd_lrb *lrbp)
> >                  if (rgn->reads == ACTIVATION_THRESHOLD)
> >                          activate = true;
> >                  spin_unlock_irqrestore(&rgn->rgn_lock, flags);
> > -                if (activate) {
> > +                if (activate ||
> > +                    test_and_clear_bit(RGN_FLAG_UPDATE, &rgn->rgn_flags)) {
> 
> How about merge rgn->rgn_flags to rgn_state?
This will actually not work, because a region can be e.g. active/inactive and dirty,
And I don't want to mess with the regions state machine.

Thanks,
Avri

> 
> Thanks,
> Daejun

  parent reply	other threads:[~2021-03-02 10:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26  8:32 [PATCH v4 0/9] Add Host control mode to HPB Avri Altman
2021-02-26  8:32 ` [PATCH v4 1/9] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-02-26  8:32 ` [PATCH v4 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-02-26  8:32 ` [PATCH v4 3/9] scsi: ufshpb: Add region's reads counter Avri Altman
2021-02-26  8:32 ` [PATCH v4 4/9] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-02-26  8:32 ` [PATCH v4 5/9] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-02-26  8:32 ` [PATCH v4 6/9] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-02-26  8:32 ` [PATCH v4 7/9] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-02-26  8:32 ` [PATCH v4 8/9] scsi: ufshpb: Add support for host control mode Avri Altman
2021-02-26  8:33 ` [PATCH v4 9/9] scsi: ufshpb: Make host mode parameters configurable Avri Altman
     [not found] ` <CGME20210226083447epcas2p2f68ef00a935d25bd2cfc930d1ef1f4f7@epcms2p3>
2021-03-02  8:20   ` [PATCH v4 6/9] scsi: ufshpb: Add hpb dev reset response Daejun Park
2021-03-02  8:51     ` Avri Altman
2021-03-02  9:32     ` Avri Altman [this message]
     [not found] ` <CGME20210226083459epcas2p1862e3e2c18208074336cc9faf14a7139@epcms2p7>
2021-03-02  8:26   ` [PATCH v4 7/9] scsi: ufshpb: Add "Cold" regions timer Daejun Park
2021-03-02  8:45     ` Avri Altman
     [not found]     ` <CGME20210226083459epcas2p1862e3e2c18208074336cc9faf14a7139@epcms2p4>
2021-03-02  9:04       ` Daejun Park
     [not found] ` <CGME20210226083422epcas2p2d39acff666e2cb9ed97bc2d5c7a8df6f@epcms2p5>
2021-03-02  8:31   ` [PATCH v4 3/9] scsi: ufshpb: Add region's reads counter Daejun Park
2021-03-02  9:19     ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB65752B178AD8CC166D165882FC999@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=Avi.Shchislowski@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=ymhungry.lee@samsung.com \
    --cc=zangleigang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®