mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Jens Wiklander <jens.wiklander@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"op-tee@lists.trustedfirmware.org"
	<op-tee@lists.trustedfirmware.org>,
	"Shyam Saini" <shyamsaini@linux.microsoft.com>,
	"Jerome Forissier" <jerome.forissier@linaro.org>,
	"Sumit Garg" <sumit.garg@linaro.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Tomas Winkler" <tomas.winkler@intel.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: RE: [PATCH v3 1/3] rpmb: add Replay Protected Memory Block (RPMB) subsystem
Date: Mon, 25 Mar 2024 08:07:49 +0000	[thread overview]
Message-ID: <DM6PR04MB65755A95AA492565F7576D10FC362@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <CAPDyKFp5j+L=oE1uVyUdu7rVLxRcueWwP0XcNTTMMrFQgmeZiw@mail.gmail.com>

> > +struct rpmb_frame {
> > +       u8     stuff[196];
> > +       u8     key_mac[32];
> > +       u8     data[256];
> > +       u8     nonce[16];
> > +       __be32 write_counter;
> > +       __be16 addr;
> > +       __be16 block_count;
> > +       __be16 result;
> > +       __be16 req_resp;
> > +} __packed;
> 
> I haven't looked at the NVME or the UFS spec in detail. Although, I assume the
> above frame makes sense for those types of interfaces/protocols too?
The rpmb implementation in ufs, has drifted apart from eMMC. E.g. in UFS4.0:
 -  the frame is different - see struct ufs_arpmb_meta in include/uapi/scsi/scsi_bsg_ufs.h,
 - Additional extended header was added,
 - the frame size is no longer 512Bytes (256Bytes meta info + 256Bytes data) but 4k,
 - there are 9 rpmb operations instead of 7, 
 - The atomicity requirement of the command sequence was waved,
And probably more differences that I forgot.
This is why it is better to designated this as an eMMC-only implementation?

Thanks,
Avri


  reply	other threads:[~2024-03-25  8:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 15:31 [PATCH v3 0/3] " Jens Wiklander
2024-02-27 15:31 ` [PATCH v3 1/3] rpmb: add " Jens Wiklander
2024-03-05 12:24   ` Linus Walleij
2024-03-05 12:55     ` Winkler, Tomas
2024-03-05 15:30       ` Jens Wiklander
2024-03-05 16:33     ` Avri Altman
2024-03-05 16:37       ` Arnd Bergmann
2024-03-05 16:42         ` Avri Altman
2024-04-03  8:54     ` Jens Wiklander
2024-03-05 12:29   ` Linus Walleij
2024-03-05 12:54     ` Winkler, Tomas
2024-03-05 14:16       ` Linus Walleij
2024-03-22 16:25   ` Ulf Hansson
2024-03-25  8:07     ` Avri Altman [this message]
2024-03-25  8:22       ` Winkler, Tomas
2024-03-25 13:33         ` Ulf Hansson
2024-03-25 13:44         ` Jens Wiklander
2024-03-28  6:58     ` Jens Wiklander
2024-02-27 15:31 ` [PATCH v3 2/3] mmc: block: register RPMB partition with the RPMB subsystem Jens Wiklander
2024-02-27 15:31 ` [PATCH v3 3/3] optee: probe RPMB device using " Jens Wiklander
2024-03-01 10:28   ` Sumit Garg
2024-03-28 16:09     ` Jens Wiklander
2024-04-03 12:58       ` Sumit Garg
2024-04-03 14:41         ` Jens Wiklander
2024-04-05  7:15           ` Sumit Garg
2024-04-05 11:39             ` Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB65755A95AA492565F7576D10FC362@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=alex.bennee@linaro.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bvanassche@acm.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=rdunlap@infradead.org \
    --cc=shyamsaini@linux.microsoft.com \
    --cc=sumit.garg@linaro.org \
    --cc=tomas.winkler@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®