From: Avri Altman <Avri.Altman@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bean Huo <beanhuo@micron.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] scsi: ufs: Re-use device management locking code
Date: Tue, 5 Mar 2024 19:51:32 +0000 [thread overview]
Message-ID: <DM6PR04MB65756CFC4DDEDC31BA4ED715FC222@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <f6045888-bb53-4ba2-90a9-98fc6a5254ad@acm.org>
> On 3/4/24 01:23, Avri Altman wrote:
> > /**
> > * ufshcd_exec_dev_cmd - API for sending device management requests
> > * @hba: UFS hba
> > @@ -3291,11 +3305,6 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
> > struct ufshcd_lrb *lrbp;
> > int err;
> >
> > - /* Protects use of hba->reserved_slot. */
> > - lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > - down_read(&hba->clk_scaling_lock);
> > -
> > lrbp = &hba->lrb[tag];
> > lrbp->cmd = NULL;
> > err = ufshcd_compose_dev_cmd(hba, lrbp, cmd_type, tag);
>
> Please restore the lockdep_assert_held() call.
Done.
>
> > - /* Protects use of hba->reserved_slot. */
> > - lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > - down_read(&hba->clk_scaling_lock);
> > -
> > lrbp = &hba->lrb[tag];
> > lrbp->cmd = NULL;
> > lrbp->task_tag = tag;
>
> Same comment here - please restore the lockdep_assert_held() call.
Done.
Thanks,
Avri
>
> Otherwise this patch looks good to me.
>
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2024-03-05 19:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:23 [PATCH 0/4] Re-use device management code fragments Avri Altman
2024-03-04 9:23 ` [PATCH 1/4] scsi: ufs: Re-use device management locking code Avri Altman
2024-03-05 19:04 ` Bart Van Assche
2024-03-05 19:51 ` Avri Altman [this message]
2024-03-04 9:23 ` [PATCH 2/4] scsi: ufs: Re-use exec_dev_cmd Avri Altman
2024-03-05 19:09 ` Bart Van Assche
2024-03-05 19:54 ` Avri Altman
2024-03-05 20:11 ` Bart Van Assche
2024-03-05 20:27 ` Avri Altman
2024-03-04 9:23 ` [PATCH 3/4] scsi: ufs: Re-use compose_dev_cmd Avri Altman
2024-03-05 19:13 ` Bart Van Assche
2024-03-04 9:23 ` [PATCH 4/4] scsi: ufs: Re-use compose_devman_upiu Avri Altman
2024-03-05 19:15 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB65756CFC4DDEDC31BA4ED715FC222@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®