mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] scsi: ufs: Zero utp_upiu_req at the beginning of each command
Date: Fri, 20 Sep 2024 19:01:07 +0000	[thread overview]
Message-ID: <DM6PR04MB6575F21241AD2B765375B715FC6C2@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <0caf3cfa-d1ec-44b3-b2db-1d95a33567ec@acm.org>

> On 9/19/24 1:41 AM, Avri Altman wrote:
> > +static void __ufshcd_setup_cmd(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp,
> > +                          struct scsi_cmnd *cmd, u8 lun, int tag) {
> > +     memset(lrbp->ucd_req_ptr, 0, sizeof(*lrbp->ucd_req_ptr));
> > +
> > +     lrbp->cmd = cmd;
> > +     lrbp->task_tag = tag;
> > +     lrbp->lun = lun;
> > +     ufshcd_prepare_lrbp_crypto(cmd ? scsi_cmd_to_rq(cmd) : NULL,
> > +lrbp); }
> 
> This function does not use the 'hba' argument so please remove that
> argument. Otherwise this patch looks good to me.
Done.

Thanks,
Avri
> 
> Thanks,
> 
> Bart.

      reply	other threads:[~2024-09-20 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19  8:41 Avri Altman
2024-09-20 18:28 ` Bart Van Assche
2024-09-20 19:01   ` Avri Altman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB6575F21241AD2B765375B715FC6C2@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®