mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Bean Huo <huobean@gmail.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Bean Huo <beanhuo@micron.com>,
	Daejun Park <daejun7.park@samsung.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: RE: [PATCH v3] scsi: ufshpb: Opt out pre-reqs from HPB2.0 flows
Date: Sat, 30 Oct 2021 10:12:09 +0000	[thread overview]
Message-ID: <DM6PR04MB6575F504229146B3C465C8EBFC889@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <0f81b6d74a6bde6606ac93e20b65cc59b9bed5df.camel@gmail.com>

> >
> > +       ufshpb_prep(hba, lrbp);
> 
> 
> it is better to add one line comment to highlight that HPB preperation
> failure will not impact original read request.
Will do.

> 
> Reviewed-by: Bean Huo <beanhuo@micron.com>
> Tested-by: Bean Huo <beanhuo@micron.com>
Thanks.

We are still not handling max-single-cmd properly.
I will issue another fix later on this week, once Martin picks this one. 

Thanks,
Avri
> 
> 
> Bean
> 
> 
> 


  reply	other threads:[~2021-10-30 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30  6:23 Avri Altman
2021-10-30  7:15 ` Bean Huo
2021-10-30 10:12   ` Avri Altman [this message]
2021-10-30 10:57     ` Avri Altman
2021-10-30 14:06       ` Martin K. Petersen
2021-10-30 14:04 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB6575F504229146B3C465C8EBFC889@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=daejun7.park@samsung.com \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®