From: "Rosen Penev" <rosenp@gmail.com>
To: "Bartosz Golaszewski" <brgl@kernel.org>,
"Rosen Penev" <rosenp@gmail.com>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"open list" <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v4] gpio: mvebu: fix Armada XP per-CPU mask register save/restore
Date: Mon, 19 Oct 2026 01:09:05 -0700 [thread overview]
Message-ID: <DM8NTXCWM1GK.AA1YGD7D8E60@gmail.com> (raw)
In-Reply-To: <CAMRc=MeUt=dwZUybCx=JUvDs9ZWa8Zyg6DzJy_bxwzn_k=RgFA@mail.gmail.com>
On Mon Oct 19, 2026 at 12:59 AM PDT, Bartosz Golaszewski wrote:
> On Mon, 19 Oct 2026 01:01:17 +0200, Rosen Penev <rosenp@gmail.com> said:
>> The Armada XP variant keeps the per-CPU edge/level mask registers in a
>> second I/O window (percpu_regs) rather than in the main GPIO window.
>> The suspend and resume paths however read and wrote them through
>> mvchip->regs with the per-CPU offsets, which hits the global
>> GPIO_EDGE_MASK / GPIO_LEVEL_MASK registers instead. Per-CPU mask state
>> was therefore lost across suspend/resume, so a level line could end up
>> unmasked behind genirq's back and trigger an interrupt storm once
>> interrupts are re-enabled.
>>
>> Use mvchip->percpu_regs for the Armada XP per-CPU mask registers in
>> both the suspend save and the resume restore paths, matching the
>> mask/unmask handlers and the probe-time masking.
>>
>> Fixes: b5b7b487431b ("gpio: mvebu: add suspend/resume support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>> ---
>> v4: rebase again
>> v3: rebase again
>> v2: rebase
>
> Are you rebasing it on top of the gpio/for-next branch of the GPIO git tree
> as indicated in MAINTAINERS? Because this still fails to apply. :(
I cloned it, yes.
>
> Bart
prev parent reply other threads:[~2026-10-19 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 23:01 Rosen Penev
2026-10-19 7:59 ` Bartosz Golaszewski
2026-10-19 8:09 ` Rosen Penev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8NTXCWM1GK.AA1YGD7D8E60@gmail.com \
--to=rosenp@gmail.com \
--cc=acourbot@nvidia.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®