From: "Cao, Bingbu" <bingbu.cao@intel.com>
To: Ma Ke <make24@iscas.ac.cn>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"Zhang, Lixu" <lixu.zhang@intel.com>,
"stanislaw.gruszka@linux.intel.com"
<stanislaw.gruszka@linux.intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: [PATCH v3] media: pci: intel: ivsc: fix error handling in mei_ace driver
Date: Tue, 23 Sep 2025 03:06:39 +0000 [thread overview]
Message-ID: <DM8PR11MB56530EE7AB645AA3779AD69B991DA@DM8PR11MB5653.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250923020944.33565-1-make24@iscas.ac.cn>
Hi, Ke
Better update the subject, it's not related to error handling.
------------------------------------------------------------------------
BRs,
Bingbu Cao
>-----Original Message-----
>From: Ma Ke <make24@iscas.ac.cn>
>Sent: Tuesday, September 23, 2025 10:10 AM
>To: sakari.ailus@linux.intel.com; Cao, Bingbu <bingbu.cao@intel.com>;
>Zhang, Lixu <lixu.zhang@intel.com>; stanislaw.gruszka@linux.intel.com;
>mchehab@kernel.org
>Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
>akpm@linux-foundation.org; Ma Ke <make24@iscas.ac.cn>
>Subject: [PATCH v3] media: pci: intel: ivsc: fix error handling in
>mei_ace driver
>
>The mei_ace driver contains a device reference count leak in
>mei_ace_setup_dev_link() where device_find_child_by_name() increases
>the reference count of the found device but this reference is not
>properly decreased in the success path. Add put_device() in
>mei_ace_setup_dev_link() and delete put_device() in mei_ace_remove(),
>which ensures that the reference count of the device is correctly
>managed regardless of whether the probe is successful or fails.
>
>Found by code review.
>
>Signed-off-by: Ma Ke <make24@iscas.ac.cn>
>---
>Changes in v3:
>- deleted the tag of Fixes and CC, and moved put_device() to
>immediately after device_link_add() as suggestions; Changes in v2:
>- modified the put_device() operations and the patch title as
>suggestions.
>---
> drivers/media/pci/intel/ivsc/mei_ace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/pci/intel/ivsc/mei_ace.c
>b/drivers/media/pci/intel/ivsc/mei_ace.c
>index 98310b8511b1..9969c02da671 100644
>--- a/drivers/media/pci/intel/ivsc/mei_ace.c
>+++ b/drivers/media/pci/intel/ivsc/mei_ace.c
>@@ -414,6 +414,7 @@ static int mei_ace_setup_dev_link(struct mei_ace
>*ace)
> /* setup link between mei_ace and mei_csi */
> ace->csi_link = device_link_add(csi_dev, dev, DL_FLAG_PM_RUNTIME
>|
> DL_FLAG_RPM_ACTIVE |
>DL_FLAG_STATELESS);
>+ put_device(csi_dev);
> if (!ace->csi_link) {
> ret = -EINVAL;
> dev_err(dev, "failed to link to %s\n", dev_name(csi_dev));
>@@ -522,7 +523,6 @@ static void mei_ace_remove(struct mei_cl_device
>*cldev)
> cancel_work_sync(&ace->work);
>
> device_link_del(ace->csi_link);
>- put_device(ace->csi_dev);
>
> pm_runtime_disable(&cldev->dev);
> pm_runtime_set_suspended(&cldev->dev);
>--
>2.17.1
prev parent reply other threads:[~2025-09-23 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 2:09 Ma Ke
2025-09-23 3:06 ` Cao, Bingbu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB56530EE7AB645AA3779AD69B991DA@DM8PR11MB5653.namprd11.prod.outlook.com \
--to=bingbu.cao@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=make24@iscas.ac.cn \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®