mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Igor Belwon" <igor.belwon@mentallysanemainliners.org>
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>,
	"Igor Belwon" <igor.belwon@mentallysanemainliners.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add support for Xiaomi 17 Ultra phones
Date: Mon, 19 Oct 2026 15:41:05 +0200	[thread overview]
Message-ID: <DM8UW484M1QM.1HU5NBOJ8TDDF@mentallysanemainliners.org> (raw)
In-Reply-To: <srwzxkzxbbgtlnhp6nndneoh6wgmfuheryxkaezi3jyps6f23c@jj7bgtezypqm>

Hi Abel!

Thanks for your review.

On Mon Oct 19, 2026 at 12:57 PM CEST, Abel Vesa wrote:
> On 26-10-18 11:17:57, Igor Belwon wrote:
>> The Xiaomi 17 Ultra device, codenamed 'nezha', is a flagship mobile
>> phone released by Xiaomi in 2025 (China)/2026 (EEA). It uses the
>> Qualcomm Kaanapali SoC.
>> 
>> This device's configuration is based on the 'MTP' from Qualcomm,
>> as is also referenced in the downstream sources. Apart from the
>> usual differences (i.e. codecs, panel), it also uses the newer
>> WCN7860 (peach) connectivity chip, which is why WiFi/BT are not
>> brought up.
>> 
>> The difference between the EEA and the Chinese model is the battery
>> capacity, notably, the EEA model has a smaller 6000 mAh battery when
>> compared to the CN 6800 mAh SiC battery.
>> 
>> Currently implemented features are:
>>  - Booting
>>  - Power and volume keys
>>  - Storage (UFS)
>>  - USB-C Peripheral and Host modes
>>  - GPU
>>  - Fuel gauge
>>  - ADSP, CDSP, SoCCP remote processors
>> 
>> Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>

[snip]

>> +		sleep_clk: sleep-clk {
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <32000>;
>
> Is this not 32764 ?
>

Downstream specifies 32000:
- https://github.com/MiCode/kernel_devicetree/blob/popsicle-w-oss/qcom/canoe.dtsi#L1439

>> +			#clock-cells = <0>;
>> +		};

Ack for the rest.

Warm regards,
Igor


      reply	other threads:[~2026-10-19 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  9:17 [PATCH v3 0/2] arm64: dts: qcom: Add support for the Xiaomi 17 Ultra series of devices Igor Belwon
2026-10-18  9:17 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Document Xiaomi 17 Ultra devices Igor Belwon
2026-10-18  9:17 ` [PATCH v3 2/2] arm64: dts: qcom: Add support for Xiaomi 17 Ultra phones Igor Belwon
2026-10-19 10:57   ` Abel Vesa
2026-10-19 13:41     ` Igor Belwon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8UW484M1QM.1HU5NBOJ8TDDF@mentallysanemainliners.org \
    --to=igor.belwon@mentallysanemainliners.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®