From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Gary Guo" <gary@garyguo.net>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Benno Lossin" <lossin@kernel.org>
Cc: <nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
"dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH] gpu: nova-core: replace unsafe pointer cast with pin-init self-reference
Date: Tue, 20 Oct 2026 09:56:14 +0900 [thread overview]
Message-ID: <DM9991XFZM69.2G13TB49VYPJU@nvidia.com> (raw)
In-Reply-To: <20261019133647.1279779-1-gary@kernel.org>
On Mon Oct 19, 2026 at 10:36 PM JST, Gary Guo wrote:
> From: Gary Guo <gary@garyguo.net>
>
> Nova core's driver data makes use of a few unsafe self-references for
> device resources. Replace them with pin-init's self reference feature
> instead.
>
> `auxiliary::Registration` is only allowed to capture a single lifetime, but
> it needs to capture `&'gpu Gpu<'bar>`. However, we cannot use coercion here
> as `Gpu` is invariant over `'bar`. As we know that `'bar` outlives `'gpu`,
> use pin-init's existential lifetime to erase the `'bar` lifetime in
> `NovaCoreApi`.
>
> Swap bar1 and bar0's drop order to make pin-init happy.
>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---
Reviewed-by: Eliot Courtney <ecourtney@nvidia.com>
prev parent reply other threads:[~2026-10-20 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 13:36 Gary Guo
2026-10-20 0:56 ` Eliot Courtney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM9991XFZM69.2G13TB49VYPJU@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel-bounces@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®