Re: [PATCH] mtd: spi-nor: fix missing space after comma in legacy flash names

["Michael Walle" <mwalle@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]

On Fri Oct 23, 2026 at 11:24 AM CEST, Shuai Liu wrote:
> Add the missing space between string literals in the legacy
> flash_info entries. Cosmetic only, no functional change; silences
> checkpatch ERRORs on these lines.
>
> Signed-off-by: Shuai Liu <847807867@qq.com>
> ---
>  drivers/mtd/spi-nor/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 8bc117b46..31cba60bd 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3898,11 +3898,11 @@ static const struct spi_device_id spi_nor_dev_ids[] = {
>  	 */
>  	{"at25df321a"},	{"at25df641"},	{"at26df081a"},
>  	{"mx25l4005a"},	{"mx25l1606e"},	{"mx25l6405d"},	{"mx25l12805d"},
> -	{"mx25l25635e"},{"mx66l51235l"},
> +	{"mx25l25635e"}, {"mx66l51235l"},
>  	{"n25q064"},	{"n25q128a11"},	{"n25q128a13"},	{"n25q512a"},
>  	{"s25fl256s1"},	{"s25fl512s"},	{"s25sl12801"},	{"s25fl008k"},
>  	{"s25fl064k"},
> -	{"sst25vf040b"},{"sst25vf016b"},{"sst25vf032b"},{"sst25wf040"},
> +	{"sst25vf040b"}, {"sst25vf016b"}, {"sst25vf032b"}, {"sst25wf040"},
>  	{"m25p40"},	{"m25p80"},	{"m25p16"},	{"m25p32"},
>  	{"m25p64"},	{"m25p128"},
>  	{"w25x80"},	{"w25x32"},	{"w25q32"},	{"w25q32dw"},

Well, that is because they are aligned with all the other entries.
IMHO this is just unneeded code churn.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]