From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.196.32 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793135441; b=FTQGB5qSnJaiCyoiWbOi0ViECsrThtSqZUae6INOS0utN0C0s0HTTzkmckVZhcXJwZTr hZN2o+vWIy4OpLqIlgaA8tAwlLqOO2W99tgmd9YAOhfM6NS0lmC4jq7d4imgCfUPLkl00 hwuHe8St88OK0YcSRu1gYaHgjcyK3LKPyiHRSVUVUKVqKWUqOjYW7XziM2lsH6Wk4oVsQ uwW5EBsRhwQWCeYGbnfa25CaXTS85nsPIL6zpgmhvhY+1rQQ6W1iwVPZrWW50zjWlib6K fMKi6DwsGlpKdH6/t4SEwqwsX2pS2QKy7YYPeBkTipfwv5LF31TjeOcVSjCO9E7lW6Q== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793135441; h=DMARC-Filter:DKIM-Signature:Received:Received: Content-Transfer-Encoding:Content-Type:Date:Message-Id:Cc:To:From: Subject:X-Mailer:References:In-Reply-To:X-ClientProxiedBy: MIME-Version:X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=joa3AxqeUObolrsuwJzh7TiY4r/2iQfMSE/c3S5Aeig=; b=tVAtn5sDWvu0LrtH45mzQ5FkuSrR8Oi14F7i/gKYDEfYQOfTSOQdG7pyV9/i2Zucw8i3 oEA6SVZnIfkiQDZlPfNb+dmK1DIdk2aIoZk43+SmlJVvzHiqqo/I5Z3hiEu+ECZe9Fn/y CCQv2wHtUxCasY33lS34Se0ewt5YjBJe8od40b4j9lBnS/2sv7rJG/2Q0O5mm9lfR0BUa cZ4ylhl1OBZ09unkzpCRniTSPnx0RGZJPfgArFB5PwGSJBKesT5cBR/Uer+ToqC4eia31 wQKsipnxexmJ7v26zv7niDuwUSWKylS8QuHZ606EC1Q9zqJq1cMrcZWL9QFlHzM5nRw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=KGezkC8n; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.196.32 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013032.outbound.protection.outlook.com [40.93.196.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C10E9606A31F; Tue, 27 Oct 2026 21:10:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C10E9606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=KGezkC8n ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y+msr3pIv1yybBmAj1X3nNBhN7z6z+nBW2tGqDaBGsmdT8azvN1UgyBk63+RA1ofnVbktL80dUSGIXkTAhqj9w2ldKPnWZYVMrtwEqVjM5woKzsFHdG4EkZuU1apw+D7YswYssbr1pkXSFnfcAMteCu2XvCxiV/Rj7yvWr5/pFVTM07IjWWD37r2OAqMAaMhgQwOafX4XpPFkwXc/bE1ZkTB1hfgLndy0jNn/EF2vy7/GUEriHHFb1XW8CWLT7OxNivumJ+GGQEkDrgCGHi5Q7zGLZ3zvT6DuXVH5yUBSMKZfXR/rNymNi4HMGcaJf5SbjOtNvq9LhLQQgVirmZ02Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=joa3AxqeUObolrsuwJzh7TiY4r/2iQfMSE/c3S5Aeig=; b=kqeOpw7uuI4H+ZkLR9y7k8PNOpNAX5tfEL92bge92tXjYD3LmaYPa/qjWZ6Vx/py0jxSN1w4dT0Yp0qL7bTYMEKoe+3Rjq+AL3nVoz1C3ZCabnJrJHsonef8AV9gF0qrJYQfkqMsPYxYk/rL6YQ3ye3E1kKbkd16QZZLYIku7oB6+UJ9K4/fMg+4OqiJ3dN7b9SEFKmTryR4YoY2tD3/tDkyccVLnf2yTXI4NPyzaumwR6UUYTobrFOLvyR7CTyXYN3z+tZzDmX5bCw44vcHrvUyafjjAqPF85fptqJiJAGUrwKgwpI+RxWrqE1kRf9utXnqUAQCUNySwKGink48Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=joa3AxqeUObolrsuwJzh7TiY4r/2iQfMSE/c3S5Aeig=; b=KGezkC8nENubu7gTdli8/Ep7ah1oxBoA/mtcOIQrsboR/temf9iv1qIVXd8MnMHPTSyJwgli9Lv5RD30jSgLSkpwzJZXWP84Qc3c6yc/94tpu0KEn8pHa9xuBSgLi+0YOeRDR7O5zj73gYqNNitMom9oNvVnAaqNxYXnOJtvvld5dF2DyRNtObVtbxDnfyoAOt4YXBLlOshLyYKuA9Lq0aXmI0dd7xyjUwi8xUgca6P9753HVGOskPvTipbuR7JebGcfOHsYT6xbi2fcO9mK2GCbsDyvLvqkK5EnysNSpvsE/1kZqFalSm2SnH/Y32gbW5cczlDOo2MAKMYVUWL+Ug== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by IA4PR12MB243497.namprd12.prod.outlook.com (2603:10b6:207:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Tue, 27 Oct 2026 21:10:36 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%6]) with mapi id 15.21.0546.021; Tue, 27 Oct 2026 21:10:36 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 Oct 2026 17:10:32 -0400 Message-Id: Cc: , , , , , , To: "David Hildenbrand (Arm)" , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , "Matthew Wilcox (Oracle)" , "Jan Kara" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" From: "Zi Yan" Subject: Re: [PATCH 11/46] mm/huge_memory: properly handle refcounted PUD mappings on fork X-Mailer: aerc 0.22.0 References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-11-6f74bec9a5bb@kernel.org> In-Reply-To: <20261027-fixes_core-v1-11-6f74bec9a5bb@kernel.org> X-ClientProxiedBy: YQBPR01CA0147.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::8) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|IA4PR12MB243497:EE_ X-MS-Office365-Filtering-Correlation-Id: 364b219a-63e7-4001-5411-08df346ebed6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|7416014|366016|921020|261026121527099003|4143699003|56012099006|11063799006|261009223027099003|261021123027099003|261022105027099003|261021121427099003|18002099003|22082099003|10067099003|261026140227099003; X-Microsoft-Antispam-Message-Info: tqoZgkyefCD9GVaBSnYTlWVsxTjxczdpbP2bgh3oPE6qREkgkWkyLz8J0RQEl3B+IR+BMgBkNBC6LCe4ai4wTizheBvS6ZgGhyHgHXJTysqWFPHK26p7JNMTKDWpbVUcVrJ93jOWt/PfcN/MBQpmEBKhhsSPvcDXtc7D/IvV7KCM9spxan2mD/W5amMSs88wdfE89+ty+WYKW6yiPfFZY/MLWr49aBdppws+I4zyrqVBfvHTcPQaXDb74BiGw7/nA4K7LCCwwni9hDgvq3G7huTcPd6/r0vHIgtG6GkYdV+dYCpTsownHv8UI6S3JSs8nVr6iL8cww9p/ryqj3aaPtRuCqdf/4a01NZj/Fpc7WkVHPeuWuHOAhg5siS3Uxc94Mp5vVmLiYdkWnrHhVu2BKHxsBvfzsLBr7J1+KPWB4uCyTfmkF9ie3YOiExZvfQUuCesd6MRLS32gHrJJ3F21esJkM/24HlgMboMAjwlJVjdMc7dz4Ki4+Hk46fXOiDL8HOAuFoH0g8MaAI1HBdMFIjLJT77NrGmhWxFuCw3o4jxwN2kWqJZDYPD2Q0TUTGJKZl7GpuRQlovNXts6Qhy5UPz82tTwSJeG4KAmeR3Aa8WdPPgMz69KmPW4oZf0cdBfUoDmS0huGL7XqNsXODVTTG7PbXZ6wODJhbWL7AWeZ0137qikuI6MRrTtw56eFWKbR/oLem4SZ3QEW68/URhXg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(7416014)(366016)(921020)(261026121527099003)(4143699003)(56012099006)(11063799006)(261009223027099003)(261021123027099003)(261022105027099003)(261021121427099003)(18002099003)(22082099003)(10067099003)(261026140227099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVpDM1JSbEVCcU4rcWhRZnZUZVA4NjlEQWxOSEpWcnlZeXFCN012cFFZMno2?= =?utf-8?B?U29McXNpeXBxTE12VTA5R1FMVmo5RThCQTFCWmg5clA4eGt3b045UVozOFha?= =?utf-8?B?NndhL2s4ODdnbVJyYUVGSG9EM29CM1ZWR0MzMWowTk14eDNYb0VmZXp3NUtC?= =?utf-8?B?NEZZNVVvRW5xQ0JtRWMrclZmTWkzZ2QyYXdhQ2dnczhtS0ZHT1ZsejJhNzYz?= =?utf-8?B?UFMzZWRpSkQyK2dyU0p3dkF3eDdBOTZuYUdYQUVUN2NLT0dDR3NYeTlKZ2hU?= =?utf-8?B?blJVVzVYcHcxOFhJVHRnekQxamJqQmpwc2VETXV6QWE1UVl0Rms4T21YTlVI?= =?utf-8?B?ekxhZjBQTFdXaFg1bzFwOVV4NE9mSENtQVpaSHZsWVBlanpwTTN4YjY2SjJ3?= =?utf-8?B?aDMwcm8xYTBFN1I1WTlIeHFOWTFnZUFwMmtaQ083Tk5zK3VGcCs0QXlYVnIr?= =?utf-8?B?WWhyRjRLZlVRdjd5STZ4R1RMQndsSGdLMXhsUkp3MEQzcmNVM2lhNDRLQlZB?= =?utf-8?B?WXF3VE9IQm5RV2JUa3p4MkROcUdRSDdYZzk1ZjZYQTFJTGp5WDRWR3U5WXl5?= =?utf-8?B?Z3J2NHRpWFhqempQMFhYejRrQTJHTlpNNWxnbmQ2bjgvTHdsVHU1d3lrNUR4?= =?utf-8?B?Z2JnOGdWZlowVi9tSWtTU0oyNVZ6cmRSU1VmOWZOeWp1Q0F4YkpiSGJiUlQz?= =?utf-8?B?QlFoS3BReHdtaFhXZXFwVjJYamJrU0ZiaHJDSzBMemJGbS9LSGlOZzNHSDZZ?= =?utf-8?B?b25oMzZkd3VCWUttcTI5YWpIV2FGUTJ3Ty9yamlSRGgzZmxTcXZaM3JveERl?= =?utf-8?B?d0FBMHM1Vkl4bkpOVXlBdENXUTZHb0pyM2t3RXFQYjBFL1ZmcE9lQXV3NEp6?= =?utf-8?B?WVdSMEF3RVh5WjRZbEdPMkZlMnhnU2o1RjY2VncvaHFmYjVQSm1Qdy9lWmN4?= =?utf-8?B?RU1YdkVIektqa0pRZUpXbGV1d3gxcDdITW41M1lmbVFqcHFvblBSUWVYMGF2?= =?utf-8?B?VGI4RWo3OWk5Z2d6NHR1aDcyMnlhbmQraUsrVlpWV2ZxTlVWckdldHA2Z1pB?= =?utf-8?B?cjhaVzBBNHhhd3pqOVB2Q0RzYVVpbU50MzhzdkJsa3ZkeE1yRGQ4OWViaTFW?= =?utf-8?B?WXhDUUpXZ0kwekVrQmF2ZVI4UlJTUmxySzd5Rm9ncDR1ZktWSS9qYytoQ1Rr?= =?utf-8?B?dmVzbTBtWjJmZkdIOFYxR1Q3Z3RDTmwxc0c3K2tnSlVnSjV4OGlmemlXcVIv?= =?utf-8?B?ZUZncWxINjVBQmRRN1ZYT1BwUmk0aXpJYnF3TG4yOEhGcW4vc3B4VThDcVRH?= =?utf-8?B?UllVMm54b201cWVXOGpNdGpteXoyd2wrVEdyTVJLVVFFTytMUUJHKzZxUVds?= =?utf-8?B?a2l6N3E3VHN1Ykw3SGp0Y3NKbms2STBZVlJXL0VwQVAzNGZHOENjZjIvWEds?= =?utf-8?B?cFVWa2RKaUNJUkxDd3ZsVFZvcWxyRk1rTDRnektVd0pFYW9QK3hOaW1SRG45?= =?utf-8?B?ckZkSDY3RmFjdzRoQzZzWVBldUVwMFhYQUkyT2VXZVhrTnlMWmZQd1p6WVRE?= =?utf-8?B?QVR0VWw5VmJ1ek1pYmFxVkFRUHdkRkZPR09hamxSd3hlNmZkMDhWbmVTdmt4?= =?utf-8?B?YmNObkxuWXhkaktSNktZcVRRcmhmU3hlNnRocVM1UzFQeDhCVFI3VUZ4U2lj?= =?utf-8?B?V1hQNUp3bGF0cXhScFdUV2Z4Uzk3NEVzNjRzOW9lZ3JsMlRVUFVLbDlpSGR2?= =?utf-8?B?ZlA4a29jVzI1L210Y0dZRy9rVENqcHc5dlRtQlZzeDhsbjRRT3V2TVdHeVVX?= =?utf-8?B?V0toWTJsZFVhYUdjdEVBaUZHUTZRMXU3Y3FzRTBSVmMybXcwZjRhNktVOEdE?= =?utf-8?B?eG5MaHZqMGJoNjhmeVQwVFJWMlljY0lNTDBwNUFWT3JHb3FJbjRlakdzTE9v?= =?utf-8?B?dDE3MDl2QzN2NXY3cWgxLzBMQ3kvZTl1N0V4cnp0TVVVemo5NzhUU3RJRnZN?= =?utf-8?B?Y29xcWk3eHluVmQrNE5iUEdCYzFLbk4rU0gzUmMrallSZnQ0WUVrRk14UUo5?= =?utf-8?B?cEp0TFNYbXU1eWtTQkdaUmhGeDVDb3YxTWVQYlY0V1F4RTNGcVFaV2hMakRm?= =?utf-8?B?N3JUZmxYd0NnMGxBeWdobkN2SE54WFIwb2R5b2hSZ0w5U082TVVwZDRtTGQv?= =?utf-8?B?TitpVkZQUm5NNGJmaXhXeHFSOHdhMkNKay9QOFVNcXhJWklGR3JRTHhSdzBT?= =?utf-8?B?YmxnOC9NZFNsT0RJaW5hMVAxc2VWaXRBQzlCdjBYc1R3dzhlUnJyL3AwMHZi?= =?utf-8?Q?xv8vgtOTBGlTfsuQC8?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 364b219a-63e7-4001-5411-08df346ebed6 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2026 21:10:36.3668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YOffFhSYYqxdQSUeTax7Mog/FCHRaWCmwl0OxmSJ4UAH8XumVetLoQu2ABMnDzKt X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR12MB243497 On Mon Oct 26, 2026 at 7:17 PM EDT, David Hildenbrand (Arm) wrote: > copy_huge_pud() copies device-DAX entries without taking a folio referenc= e > or updating mapcounts and the child's RSS. > > For example, MADV_GUARD_INSTALL sets VM_MAYBE_GUARD on a device-DAX VMA, > forcing copy_page_range() to traverse the whole VMA on fork. Any remainin= g > huge PUDs are then copied without accounting for the new mappings. > Unmapping them in the child decrements accounting that was never added. > > Use vm_normal_page_pud() to identify refcounted mappings. Take a folio > reference and add the child's PUD rmap and RSS accounting before installi= ng > the copied entry. Pass src and dst VMAs consistently instead of src and > dst MM. Move the TODO. > > Fixes: aed877c2b4257 ("device/dax: properly refcount device dax pages whe= n mapping") > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) > --- > include/linux/huge_mm.h | 5 ++--- > mm/huge_memory.c | 27 +++++++++++++++++++-------- > mm/memory.c | 4 +--- > 3 files changed, 22 insertions(+), 14 deletions(-) > Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi