From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Vineet Gupta" <vineet.gupta@linux.dev>, <bpf@vger.kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>,
<martin.lau@linux.dev>, <eddyz87@gmail.com>, <song@kernel.org>,
<yonghong.song@linux.dev>, <jolsa@kernel.org>, <memxor@gmail.com>,
<emil@etsalapatis.com>, <ihor.solodrai@linux.dev>,
<shuah@kernel.org>, <linux-kselftest@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: don't count skipped reg_bounds cases as skipped tests
Date: Sun, 01 Nov 2026 00:59:01 +0000 [thread overview]
Message-ID: <DMJGTQ2WDH27.A1UOC3ON9WJM@gmail.com> (raw)
In-Reply-To: <20261028211921.1055711-1-vineet.gupta@linux.dev>
On Wed, Oct 28, 2026 at 02:19 PM Vineet Gupta <vineet.gupta@linux.dev> wrote:
> @@ -1581,7 +1582,7 @@ static int verify_case_op(enum num_t init_t, enum num_t cond_t,
> !assert_reg_state_eq(&tr2, &te2, "true_reg2")) {
> if (reg_state_needs_two_arcs(&fe1) || reg_state_needs_two_arcs(&fe2) ||
> reg_state_needs_two_arcs(&te1) || reg_state_needs_two_arcs(&te2)) {
> - test__skip();
> + *skipped = true;
> return 0;
> }
Applied. Thanks.
Eduard,
unrelated to this patch, needs_two_arcs() returns true for an unknown
register:
needs_two_arcs(U32, [0; U32_MAX], S32, [S32_MIN; S32_MAX])
lo = 0x80000000, hi = 0x7fffffff
lo > hi && 0 <= hi && U32_MAX >= lo
That's the full circle. It is one arc.
A random 64-bit range has unknown low 32 bits.
So reg_bounds_rand_*_u64_u64 and the like ignore every MISMATCH, it seems.
Should it return false when r1 or r2 is the full range?
next prev parent reply other threads:[~2026-11-01 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 21:19 Vineet Gupta
2026-11-01 0:59 ` Alexei Starovoitov [this message]
2026-11-01 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMJGTQ2WDH27.A1UOC3ON9WJM@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=vineet.gupta@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®