From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Pengpeng Hou" <hppiscas@163.com>, <andrzej.hajda@intel.com>
Cc: <neil.armstrong@linaro.org>, <rfoss@kernel.org>,
<laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
<jernej.skrabec@gmail.com>, <luca.ceresoli@bootlin.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/bridge: sii902x: validate I2S data lane values
Date: Wed, 04 Nov 2026 18:44:47 +0100 [thread overview]
Message-ID: <DMMM3FFSQC5C.3PDA68QJ6WR2Z@bootlin.com> (raw)
In-Reply-To: <20260920034833.18874-1-hppiscas@163.com>
On Sun Sep 20, 2026 at 5:48 AM CEST, Pengpeng Hou wrote:
> The sil,i2s-data-lanes property reader bounds the number of entries, but
> does not bound each entry's value. Those values index the four-entry
> i2s_lane_id table when the audio FIFO sequence is built.
>
> Reject unsupported lane values before indexing that table. Report the
> property name and invalid value with dev_err_probe() so the diagnostic
> identifies the faulty configuration.
>
> The issue was found by our static-analysis tool.
>
> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-11-04 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 3:48 Pengpeng Hou
2026-11-04 17:44 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMMM3FFSQC5C.3PDA68QJ6WR2Z@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hppiscas@163.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®