From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793827613; b=qUoRPnhjsIkVgBe8Rjmo+hBY64RCxUupYfbSek4fldUWJT6GqJ87ZokAHLr99rjFAMGF boRvkXeMJzjiimA14v9paRdeTg3HlG7mvOwW/Lrc/A9WJsYvdFRMD4Z58mnUecnbE5KZX 0uneLomqf2rNzOidPR37cJJY7EFk8jPHRdh8hpEv6/lNZqfxthd7pvxCZu+zNljsK14qM 8ThnIqIqWyIOZ8+3Jobsuwy9KXQdnhgje4TFUZ68Vgvyv7y+TiCEfOqs23EjbrlNNRhxt JOD4xK/pkhPDDzOYCDeRBgU+PJy0BsvVP+/tt79tml9Mqznw8MXSykfwloj4Um0IgIg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793827613; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Transfer-Encoding:Content-Type:Date:Message-Id: Cc:Subject:From:To:X-Mailer:References:In-Reply-To; bh=Fx8mwjCrbZCWbiZSWWBXN0aiI/C9oFeig/QmjdPJVek=; b=Uim9QB9CqLOl3PlVOTAiShUYn46YG39bkA5HjJQdDFtdYsJqJ9iKcjxbNVIyv8CqW0Bh IoL2CdpXCOt7Nd+/+WtcuOJMehnL93hK4jc5HySbfXrAZPjLYgqXGlt2DFLNrzO/LBEwv /fwi/K304diVyeM1mg4XyyEbT+RCIkKJaGj6qeqpwtz051KjidnBfnIQizQSA/HwfjeqZ pb6vq5+aUonP2A3H1TmroDvAyniXRlPN3HYri7XAslVfJambzfxEO4hQWxILJFDMCqnJR WMyDYhG8osXiCMYCBfb1pnZpFWUqoRuzrUPxB5mzsi8z6BtJ6/KNMzRHHMhXGq5FoTw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Vy+SWiVb; arc=none smtp.remote-ip=209.85.160.180 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A84E606BA33 for ; Wed, 4 Nov 2026 21:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4A84E606BA33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Vy+SWiVb Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-537548b811aso8729881cf.3 for ; Wed, 04 Nov 2026 13:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793827612; x=1794432412; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Fx8mwjCrbZCWbiZSWWBXN0aiI/C9oFeig/QmjdPJVek=; b=Vy+SWiVb/NpXstpdw56lw+criQ5VLmL5fI7nn0T68KlPT3t+Dt/ZXXIrVA+Cb9oTH4 TPCa6A3seRH9NuwzLYB4U8f/OShYV6IlQIso/owGoN/zGKf8RjT/HHAYQiFq6Md9/AGx OQu+WfEphT/kKjXP8GvKBBFJyiAVMrQefdiWdJmUUcdvKTLoDsWtPAZotnQX9UJOrzaQ xRONIbMdbEwkr1WI3Kg4PeBEsFZ5Y37wda519hWTRbTA9zS4VszXsqzBXwuK7HvvH0Qa FvCJLDSn4KAlIWnCl9a6eAaYBJKX17NVHsnq7L+bnHg+v812XRAWefqQg5U2r0LgvExP /fLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793827612; x=1794432412; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fx8mwjCrbZCWbiZSWWBXN0aiI/C9oFeig/QmjdPJVek=; b=xtQkrLXIT4edyi1WaaWigOmUPBFXU8XmPfePAAIoQ3d688dIpw/YorNanJZAx73bIS ofQKGzbEDomyozI7AsN/RJExNs1Ra/IyIRfcoggo8usW/1KCOJgIxcqI/T1lPBW5dQMM Ohsnv9pGRAsVyXoxUqRBZuD5LxTpIyd0ZT2Kya5bhA2VS2IId7I3kT/vTFCOHioCynMk gWKfS4/1OLAQ0wnVQXZYZxLbwZxMDLN2ErzYEOnYuf5b4FWzzctHX9a+aqlEPkRD2pk6 hkATibrxxFWXFfwOknYMBXxILT2kb5McDp59qCTQtIC8yOfdIy4DBkCYkM92gpnZoxHA BPlA== X-Forwarded-Encrypted: i=1; AKwUvBz+XndiFN0WX5GLL5pI9vcgysA+r4LgjcWApIbpx7Z64p7sP1reS9t3hh9L6EQlxo5xaI5CItG/JHWWywE=@vger.kernel.org X-Gm-Message-State: APuU4Z8MzjW+GD3Kf1XRDrw5OBrhar8GBh9rhaknxdOpp016jQtdKWB6 umi9oviIZVbLWngIRWe6CIaieUFE5aqikPEJTAo/DRBg4QFb2HdaUNeF X-Gm-Gg: AYBFou2tnL9XB+84+1L6/9RlKa4a/40Rn60jrd7JfKY9f9jOUrPmwxo8XzV4YU8DEvD 2BL1eV3glN+AOuF/64OSD2isHDo/mGnNu/EfUkbzdC/JmJrnUiZP6BGDQe7ALPgmCmAPVlEc6V0 4g4GiwoFuSmVLkkClUncCINCryvuEAKEXqjhnzy9s+Az2XS802/EHfqyXlDmv9cEbbe5BAcyj/V T7iV/zvPWgmCRQCcN4zOcAh+G/FXvKwev1hRNWEclgh3MMONyvUCiP2zD6XczkGXJKv75Zm6EyV tWsybcLvuuwy7lc60gOu06IRa7yjW5aC1RUq/jOw+NMVh3mzguuK++OYd3Is/vWtvwsP4U4Wsr/ mNQIITEqWTKEYmbHuRLoyVi2nvo2aajvbom95CKP4JRAxwTR5TWIXWLaNDGhsyzFcm9wmNewI2T 8BH05qyu5zaKpqfCyjfUt127pjOyvo0c2iaG+YEbaviXeIQcNUuwrvLNe7AqK+/K1BZMx5aYBtw HzxxThT/RqSHdBhIkye3IuviUqznYUfaW3q1ugg5JP8e3ao4iRrm9np2/UNO75RbDv8ZLEcZChd r3QwjlKB8ztOAC4Q X-Received: by 2002:a05:622a:2510:b0:533:8bf0:e6 with SMTP id d75a77b69052e-542b6a703c1mr284677281cf.35.1793827611998; Wed, 04 Nov 2026 13:26:51 -0800 (PST) Received: from localhost ([2620:10d:c091:500::4:a8c5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-54b10c4dcddsm34508841cf.20.2026.11.04.13.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2026 13:26:51 -0800 (PST) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Nov 2026 16:26:50 -0500 Message-Id: Cc: "Simon Horman" , "Jakub Sitnicki" , "Daniel Zahka" , "Willem de Bruijn" , , , , Subject: Re: [PATCH net v2 2/2] selftests/net: psp: test bidirectional data transfer From: "Daniel Zahka" To: "Wei Wang" , "David S . Miller" , "Jakub Kicinski" , "Paolo Abeni" , "Andrew Lunn" , "Shuah Khan" X-Mailer: aerc 0.21.0-threadmapfix References: <20261030043145.2185700-1-weiwan@google.com> <20261030043145.2185700-3-weiwan@google.com> In-Reply-To: <20261030043145.2185700-3-weiwan@google.com> On Fri Oct 30, 2026 at 12:31 AM EDT, Wei Wang wrote: > _data_basic_send() and _data_basic_send_netkit_psp_assoc() currently > only verify unidirectional data transmission from the test socket to > psp_responder. As a result, they do not exercise the receive path for > PSP-encrypted TCP data segments arriving at the test socket (such as > packets redirected across a netkit interface associated via dev-assoc, > which relies on SKB_EXT_PSP surviving packet scrubbing). > > Use the existing "data echo" command in psp_responder to verify that the > test socket can also receive PSP-encrypted data from the peer in both > _data_basic_send() and _data_basic_send_netkit_psp_assoc(). > > Signed-off-by: Wei Wang > --- > tools/testing/selftests/drivers/net/psp.py | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/s= elftests/drivers/net/psp.py > index 473500901879..e507951b440b 100755 > --- a/tools/testing/selftests/drivers/net/psp.py > +++ b/tools/testing/selftests/drivers/net/psp.py > @@ -120,6 +120,12 @@ def _check_data_rx(cfg, exp_len): > ksft_eq(read_len, exp_len) > =20 > =20 > +def _check_data_echo(cfg, s): > + _send_with_ack(cfg, b'data echo\0') > + s.settimeout(1.0) I'm not a huge fan of setting the blocking timeout here. If we are going to set a timeout it should be when the socket is created. Otherwise this function has an unexpected side-effect. Another option is to use non blocking reads with timeout like: def _recv_careful(s, target, timeout=3D2): """Read exactly target bytes, tolerating short reads""" data =3D b'' end =3D time.monotonic() + timeout while time.monotonic() < end: try: data +=3D s.recv(target - len(data), socket.MSG_DONTWAIT) if len(data) =3D=3D target: return data except BlockingIOError: time.sleep(0.001) raise KsftFailEx(f"short read, got {len(data)} of {target} bytes") def _req_echo(cfg, s): """Ask the peer to echo, and check the reply arrives intact""" _send_with_ack(cfg, b'data echo\0') ksft_eq(_recv_careful(s, 5), b'echo\0') > + ksft_eq(s.recv(5), b'echo\0') > + > + > def _check_data_outq(s, exp_len, force_wait=3DFalse): > outq =3D 0 > for _ in range(10): > @@ -478,6 +484,7 @@ def _data_basic_send(cfg, version, ipver): > =20 > data_len =3D _send_careful(cfg, s, 100) > _check_data_rx(cfg, data_len) > + _check_data_echo(cfg, s) > _close_psp_conn(cfg, s) > =20 > =20 > @@ -726,6 +733,7 @@ def _data_basic_send_netkit_psp_assoc(cfg, version, i= pver): > =20 > data_len =3D _send_careful(cfg, sock, 100) > _check_data_rx(cfg, data_len) > + _check_data_echo(cfg, sock) > _close_psp_conn(cfg, sock) > =20 > =20 I'm ok with the approach overall. The coverage is sufficient for the purposes of the series.