mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Francesco Giandinoto" <testata.nucleare13@gmail.com>,
	"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>
Cc: "Teddy Wang" <teddy.wang@siliconmotion.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: make g_fbmode constant array
Date: Thu, 05 Nov 2026 18:21:32 -0600	[thread overview]
Message-ID: <DMNP5QPGP3Y1.2V7SL7MODHHC5@gmail.com> (raw)
In-Reply-To: <20261105211344.17532-1-testata.nucleare13@gmail.com>

On Thu Nov 5, 2026 at 3:13 PM CST, Francesco Giandinoto wrote:
> The g_fbmode variable is used as an array of constant string pointers. Add the missing const qualifier to clean up the source code and adhere to kernel coding standards

This doesn't compile. Also, please keep log messages at 75 characters
per line.

Thanks,

ET

      reply	other threads:[~2026-11-06  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 21:13 Francesco Giandinoto
2026-11-06  0:21 ` Ethan Tidmore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMNP5QPGP3Y1.2V7SL7MODHHC5@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    --cc=testata.nucleare13@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®