mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexey Klimov" <alexey.klimov@linaro.org>
To: <linux-pm@vger.kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>
Subject: Re: [thermal: thermal/linux-next] thermal/drivers/samsung: acpm-tmu: Rename platform driver to "exynos-acpm-tmu"
Date: Wed, 11 Nov 2026 00:42:24 +0000	[thread overview]
Message-ID: <DMRYQFZGG5ZI.2T97YA5MCL74Y@linaro.org> (raw)
In-Reply-To: <179389375857.1009794.283716939057872036.tip-bot2@tip-bot2>

On Thu Nov 5, 2026 at 3:49 PM GMT, thermal-bot for Tudor Ambarus wrote:
> The following commit has been merged into the thermal/linux-next branch of thermal:
>
> Commit-ID:     ba446bdd27d4a2a6c0cb267f51a6ecc47cf19cf9
> Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//ba446bdd27d4a2a6c0cb267f51a6ecc47cf19cf9
> Author:        Tudor Ambarus <tudor.ambarus@linaro.org>
> AuthorDate:    Mon, 26 Oct 2026 16:01:28 
> Committer:     Daniel Lezcano <daniel.lezcano@kernel.org>
> CommitterDate: Tue, 03 Nov 2026 19:51:51 +01:00
>
> thermal/drivers/samsung: acpm-tmu: Rename platform driver to "exynos-acpm-tmu"

Also, the fix for this problem was sent here earlier:
https://lore.kernel.org/linux-samsung-soc/20261020-acpm-thermal-drv-name-fix-v1-1-71f72280583b@linaro.org/

Why taking this one and ignoring the fix that was sent earlier -- this
should be at least explained.

> Rename the platform driver from "gs-tmu" to "exynos-acpm-tmu" to reflect
> that the ACPM TMU architecture is shared across Samsung Exynos SoCs
> (such as GS101, AutoV920, and Exynos850) rather than being specific to
> GS101, matching "exynos-acpm-protocol" in drivers/firmware/samsung/.
>
> Suggested-by: Alexey Klimov <alexey.klimov@linaro.org>

I don't recall suggesting this. Reporting -- yes, but not renaming to
"exynos-acpm-tmu".

This was reported months ago and was never fixed in the updated
series for acpm-tmu.c.

> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
> Link: https://patch.msgid.link/20261026-acpm-tmu-fixes-v1-11-0637431b7268@linaro.org
> ---
>  drivers/thermal/samsung/acpm-tmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/acpm-tmu.c b/drivers/thermal/samsung/acpm-tmu.c
> index 42b338d..2324efc 100644
> --- a/drivers/thermal/samsung/acpm-tmu.c
> +++ b/drivers/thermal/samsung/acpm-tmu.c
> @@ -597,7 +597,7 @@ static const struct dev_pm_ops acpm_tmu_pm_ops = {
>  
>  static struct platform_driver acpm_tmu_driver = {
>  	.driver = {
> -		.name   = "gs-tmu",
> +		.name   = "exynos-acpm-tmu",

It is minor but it potentially clashes with exynos-acpm-tmu firmware
file name. All other names in file acpm-tmu.c are "acpm-tmu".


  parent reply	other threads:[~2026-11-11  0:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 16:01 [PATCH 00/15] thermal/drivers/samsung: acpm-tmu: Fixes and cleanups for GS101 TMU Tudor Ambarus
2026-10-26 16:01 ` [PATCH 01/15] thermal/drivers/samsung: Select REGMAP_MMIO for EXYNOS_ACPM_THERMAL Tudor Ambarus
2026-10-26 16:01 ` [PATCH 02/15] thermal/drivers/samsung: Depend on PM " Tudor Ambarus
2026-10-26 16:01 ` [PATCH 03/15] thermal/drivers/samsung: acpm-tmu: Fix acpm_tmu_resume() error handling Tudor Ambarus
2026-10-26 16:01 ` [PATCH 04/15] thermal/drivers/samsung: acpm-tmu: Disable IRQ across system suspend/resume Tudor Ambarus
2026-10-26 16:01 ` [PATCH 05/15] thermal/drivers/samsung: acpm-tmu: Implement .change_mode() callback Tudor Ambarus
2026-10-26 16:01 ` [PATCH 06/15] thermal/drivers/samsung: acpm-tmu: Rely on devres for probe error and remove teardown Tudor Ambarus
2026-10-26 16:01 ` [PATCH 07/15] thermal/drivers/samsung: acpm-tmu: Return -ENODATA when sensor is disabled Tudor Ambarus
2026-10-26 16:01 ` [PATCH 08/15] thermal/drivers/samsung: acpm-tmu: Annotate lockless sensor->enabled access Tudor Ambarus
2026-10-26 16:01 ` [PATCH 09/15] thermal/drivers/samsung: acpm-tmu: Fix IRQ locking and error handling Tudor Ambarus
2026-10-26 16:01 ` [PATCH 10/15] MAINTAINERS: Use linux-pm mailing list for Samsung Exynos ACPM thermal driver Tudor Ambarus
2026-10-26 16:01 ` [PATCH 11/15] thermal/drivers/samsung: acpm-tmu: Rename platform driver to "exynos-acpm-tmu" Tudor Ambarus
     [not found]   ` <179389375857.1009794.283716939057872036.tip-bot2@tip-bot2>
2026-11-11  0:42     ` Alexey Klimov [this message]
2026-10-26 16:01 ` [PATCH 12/15] thermal/drivers/samsung: Drop redundant composite object in Makefile Tudor Ambarus
2026-10-26 16:01 ` [PATCH 13/15] thermal/drivers/samsung: acpm-tmu: Disable regmap locking for MMIO INTPEND reads Tudor Ambarus
2026-10-26 16:01 ` [PATCH 14/15] thermal/drivers/samsung: acpm-tmu: Clean up probe error logging Tudor Ambarus
2026-10-26 16:01 ` [PATCH 15/15] thermal/drivers/samsung: acpm-tmu: Simplify pm_runtime_resume_and_get() error checks Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMRYQFZGG5ZI.2T97YA5MCL74Y@linaro.org \
    --to=alexey.klimov@linaro.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®