From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Arnd Bergmann" <arnd@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"David Lechner" <david@lechnology.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/mipi-dbi: hide unused mipi_dbi_dcs_read_commands array
Date: Thu, 12 Nov 2026 15:18:29 +0100 [thread overview]
Message-ID: <DMTAPTXHND0A.2MQ607DNUS9ZD@bootlin.com> (raw)
In-Reply-To: <20261111092404.2117072-1-arnd@kernel.org>
On Wed Nov 11, 2026 at 10:23 AM CET, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When -Wunused-const-variable is enabled and SPI is turned off, gcc
> warns about this array being unused but defined locally:
>
> drivers/gpu/drm/drm_mipi_dbi.c:79:17: error: 'mipi_dbi_dcs_read_commands' defined but not used [-Werror=unused-const-variable=]
> 79 | static const u8 mipi_dbi_dcs_read_commands[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Move it into the block that actually uses it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Could even be moved inside the only function using it.
Anyway:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-11-12 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 9:23 Arnd Bergmann
2026-11-12 14:18 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMTAPTXHND0A.2MQ607DNUS9ZD@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=david@lechnology.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®