mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Melody Olvera" <melody.olvera@oss.qualcomm.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"yzddMr6" <yzddmr6@gmail.com>
Subject: Re: [PATCH] soc: qcom: llcc-qcom Fix SM8750 settings
Date: Fri, 13 Nov 2026 10:11:20 +0100	[thread overview]
Message-ID: <DMTYT7CTC6JP.2UXJ6MWGKPX49@fairphone.com> (raw)
In-Reply-To: <20261113-topic-8750_llcc-v1-1-6536cb46d7fe@oss.qualcomm.com>

Hi Konrad,

Missing ":" after llcc-qcom in the subject?

Regards
Luca

On Fri Nov 13, 2026 at 10:01 AM CET, Konrad Dybcio wrote:
> Bring the settings in line with the with the recommendations (and also
> with the downstream kernel).
>
> Reported-by: yzddMr6 <yzddmr6@gmail.com>
> Closes: https://lore.kernel.org/linux-arm-msm/20261111-sm8750-llcc-island1-v1-1-64055702ca3f@gmail.com/
> Fixes: 2c04e58e30ce ("soc: qcom: llcc-qcom: Add support for SM8750")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/llcc-qcom.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index d7a42a8040a16388a79c24e4d1f1e88de9c87ec0..df213548637351fdaeeb81b860f0ee2631f2062a 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -3869,7 +3869,8 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.priority = 5,
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
> -		.vict_prio = true,
> +		.ovcap_en = true,
> +		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_MODPE,
>  		.slice_id = 29,
> @@ -3923,7 +3924,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.max_cap = 7936,
>  		.priority = 7,
>  		.fixed_size = true,
> -		.bonus_ways = 0x7fffffff,
> +		.res_ways = 0x7fffffff,
>  	}, {
>  		.usecase_id = LLCC_DISP_WB,
>  		.slice_id = 23,
> @@ -3946,7 +3947,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.cache_mode = 2,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMOFE,
> @@ -3956,7 +3957,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMRTIP,
> @@ -3966,7 +3967,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMSRTIP,
> @@ -3976,17 +3977,17 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMRTRF,
>  		.slice_id = 7,
>  		.max_cap = 3584,
> -		.priority = 1,
> +		.priority = 3,
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CAMSRTRF,
> @@ -3996,7 +3997,7 @@ static const struct llcc_slice_config sm8750_data[] = {
>  		.fixed_size = true,
>  		.bonus_ways = 0xffffffff,
>  		.stale_en = true,
> -		.ovcap_prio = true,
> +		.ovcap_en = true,
>  		.parent_slice_id = 33,
>  	}, {
>  		.usecase_id = LLCC_CPUSSMPAM,
>
> ---
> base-commit: 8b7179210b22f8e48a82c5ceacb9d56a9c4cfec4
> change-id: 20261113-topic-8750_llcc-bd228d96b455
>
> Best regards,



      reply	other threads:[~2026-11-13  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  9:01 Konrad Dybcio
2026-11-13  9:11 ` Luca Weiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMTYT7CTC6JP.2UXJ6MWGKPX49@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=melody.olvera@oss.qualcomm.com \
    --cc=yzddmr6@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®