From: "Gary Guo" <gary@garyguo.net>
To: "Ivan Tverdokhleb" <mbkchelofficialdev@gmail.com>,
<rust-for-linux@vger.kernel.org>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Arun Pravin" <arunpravin.paneerselvam@amd.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Lyude Paul" <lyude@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: sync: lock: allow fallible initializers in Lock::new
Date: Mon, 16 Nov 2026 12:07:55 +0000 [thread overview]
Message-ID: <DMWMG16XGPYB.W659Q8DBV6F4@garyguo.net> (raw)
In-Reply-To: <20261114200703.33229-2-mbkchelofficialdev@gmail.com>
On Sat Nov 14, 2026 at 8:07 PM GMT, Ivan Tverdokhleb wrote:
> Currently Lock::new() only accepts an infallible initializer for the
> protected data, because impl PinInit<T> defaults the error type to
> Infallible. This prevents wrapping a fallible initializer, such as
> Opaque::try_ffi_init(), in a Mutex or SpinLock.
>
> Make Lock::new() generic over the error type E, so that it accepts any
> impl PinInit<T, E> and returns impl PinInit<Self, E>. E must implement
> From<Infallible>, since initializing the lock state itself cannot fail.
>
> This is needed, for example, by the GPU buddy allocator, which has a
> TODO to move its gpu_buddy structure inside the mutex.
>
> Signed-off-by: Ivan Tverdokhleb <mbkchelofficialdev@gmail.com>
See https://lore.kernel.org/rust-for-linux/20261022160725.2215244-2-phasta@kernel.org/
which is already in linux-next.
Best,
Gary
> ---
> rust/kernel/sync/lock.rs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/rust/kernel/sync/lock.rs b/rust/kernel/sync/lock.rs
> index 10b6b5e9b024..26c071088b02 100644
> --- a/rust/kernel/sync/lock.rs
> +++ b/rust/kernel/sync/lock.rs
> @@ -128,11 +128,11 @@ unsafe impl<T: ?Sized + Send, B: Backend> Sync for Lock<T, B> {}
>
> impl<T, B: Backend> Lock<T, B> {
> /// Constructs a new lock initialiser.
> - pub fn new(
> - t: impl PinInit<T>,
> + pub fn new<E: core::convert::From<core::convert::Infallible>>(
> + t: impl PinInit<T, E>,
> name: &'static CStr,
> key: Pin<&'static LockClassKey>,
> - ) -> impl PinInit<Self> {
> + ) -> impl PinInit<Self, E> {
> pin_init!(Self {
> data <- UnsafeCell::pin_init(t),
> _pin: PhantomPinned,
> @@ -141,7 +141,7 @@ pub fn new(
> state <- Opaque::ffi_init(|slot| unsafe {
> B::init(slot, name.as_char_ptr(), key.as_ptr())
> }),
> - })
> + }? E)
> }
> }
>
next prev parent reply other threads:[~2026-11-16 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 20:06 [PATCH 0/2] " Ivan Tverdokhleb
2026-11-14 20:07 ` [PATCH 1/2] " Ivan Tverdokhleb
2026-11-16 12:07 ` Gary Guo [this message]
2026-11-14 20:07 ` [PATCH 2/2] rust: gpu: buddy: store the allocator inside the Mutex Ivan Tverdokhleb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMWMG16XGPYB.W659Q8DBV6F4@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=arunpravin.paneerselvam@amd.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=matthew.auld@intel.com \
--cc=mbkchelofficialdev@gmail.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®