mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>
To: "Jori Koolstra (CIQ)" <jkoolstra@xs4all.nl>,
	"Shuah Khan" <shuah@kernel.org>,
	"Cristian Marussi" <cristian.marussi@arm.com>
Cc: "Shuah Khan" <skhan@linuxfoundation.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests: quote tr character classes in runner.sh
Date: Mon, 16 Nov 2026 15:55:30 -0300	[thread overview]
Message-ID: <DMWV43RJBJPY.3OZT23NFSC6YU@marliere.net> (raw)
In-Reply-To: <20261116-kselftest-runner-quote-tr-v1-1-e6270326db66@xs4all.nl>

On Mon Nov 16, 2026 at 11:27 AM -03, Jori Koolstra (CIQ) wrote:
> The unquoted [:lower:] and [:upper:] arguments are subject to
> pathname expansion, so a single-character file such as 'l' or 'r'
> in the current directory would replace them and break the
> KSELFTEST_<TEST>_ARGS name sanitization. Quote them like the other
> tr invocations.
>
> Fixes: e005ff01bfdb ("selftests/kselftest/runner.sh: Pass optional command parameters in environment")
>
> Signed-off-by: Jori Koolstra (CIQ) <jkoolstra@xs4all.nl>
> ---
>  tools/testing/selftests/kselftest/runner.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 311811dc55a0..e81a35e607da 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -77,7 +77,7 @@ run_one()
>  		BASENAME_SANITIZED=$(echo "$BASENAME_TEST" | \
>  					$TR_CMD -d "[:blank:][:cntrl:]" | \
>  					$TR_CMD -c "[:alnum:]_" "_" | \
> -					$TR_CMD [:lower:] [:upper:])
> +					$TR_CMD "[:lower:]" "[:upper:]")

Reviewed-by: Ricardo B. Marlière (SUSE) <ricardo@marliere.net>

>  		kselftest_cmd_args_ref="KSELFTEST_${BASENAME_SANITIZED}_ARGS"
>  	fi
>  
>
> ---
> base-commit: 4d038dae9e5ba5b3fec87fad5b7bf3dc45523ca1
> change-id: 20261116-kselftest-runner-quote-tr-467bb5fe6dac
>
> Best regards,



      reply	other threads:[~2026-11-16 18:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:27 Jori Koolstra (CIQ)
2026-11-16 18:55 ` Ricardo B. Marlière (SUSE) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMWV43RJBJPY.3OZT23NFSC6YU@marliere.net \
    --to=ricardo@marliere.net \
    --cc=cristian.marussi@arm.com \
    --cc=jkoolstra@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®