From: "Zi Yan" <ziy@nvidia.com>
To: "Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"David Hildenbrand" <david@kernel.org>
Cc: "Lorenzo Stoakes" <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Brendan Jackman" <brendan.jackman@linux.dev>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Qi Zheng" <qi.zheng@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@meta.com>
Subject: Re: [PATCH 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast()
Date: Mon, 16 Nov 2026 16:59:59 -0500 [thread overview]
Message-ID: <DMWZ1COHLFJ8.3NI53X0OT1I2W@nvidia.com> (raw)
In-Reply-To: <20261113235238.3595412-2-joshua.hahnjy@gmail.com>
On Fri Nov 13, 2026 at 6:52 PM EST, Joshua Hahn wrote:
> zone_watermark_fast() has not used its gfp_mask argument since commit
> 2973d8229b78 ("mm: discard __GFP_ATOMIC") switched the watermark boost
> check from __GFP_ATOMIC to ALLOC_MIN_RESERVE.
>
> Remove the argument, no functional changes intended.
>
> Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>
> ---
> mm/page_alloc.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
LGTM.
Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-11-16 22:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:52 [PATCH 0/3] mm/page_alloc, vmscan: get_page_from_freelist cleanups Joshua Hahn
2026-11-13 23:52 ` [PATCH 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast() Joshua Hahn
2026-11-14 1:17 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 21:59 ` Zi Yan [this message]
2026-11-13 23:52 ` [PATCH 2/3] mm/page_alloc: move the kswapd node skip check into a helper Joshua Hahn
2026-11-14 1:45 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 22:08 ` Zi Yan
2026-11-13 23:52 ` [PATCH 3/3] mm/vmscan: consolidate promo vs. high watermark checks Joshua Hahn
2026-11-14 1:49 ` SJ Park
2026-11-16 17:22 ` Joshua Hahn
2026-11-16 21:31 ` Chris Down
2026-11-16 22:10 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMWZ1COHLFJ8.3NI53X0OT1I2W@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®