Hi, On Fri Nov 6, 2026 at 5:33 PM CET, Nuno Sá wrote: > Add support for the ISSI IS25WX01G, a 1 Gbit (128 MiB) octal NOR flash. > The part is fully described by SFDP, so only the flash ID and small > post_bfpt and post_sfdp fixups are needed. > > WRITE STATUS REGISTER (01h) takes a single data byte and only affects > status register bits 7:2, so the default 16-bit Write Status assumption > does not hold. Clear write_sr1_and_sr2 so that the single byte write_sr1 > path is taken; write_sr1 is already set to 01h by the BFPT parsing. > > The flash also has no Status Register 2. Configuration registers are read > with B5h/85h and written with B1h/81h, and the 35h Read Configuration > Register command does not exist, so clear read_sr2 as well. > > Software write protection is done through the block protect bits in the > status register: BP0-BP2 at bits 4:2, BP3 at bit 6 and a Top/Bottom bit at > bit 5, which is exactly what SPI_NOR_HAS_LOCK, SPI_NOR_4BIT_BP, > SPI_NOR_BP3_SR_BIT6 and SPI_NOR_HAS_TB describe, so set those flags to get > the generic locking support. > > The flash also supports 8D-8D-8D, but this could not be tested. Since the > SFDP has no SCCR map, the core would select 8D-8D-8D on a capable > controller but never switch the flash into it. Hence, drop the 8D-8D-8D > capabilities in a post_sfdp fixup for now. Could you please test if one (or maybe both) makes a difference here and the fixups could possibly be dropped? https://lore.kernel.org/r/20261023-spi-nor-fix-v5-1-bb6e0ce21169@nxp.com/ https://lore.kernel.org/r/20261013-winbond-master-spi-nor-w35t-v3-1-6dde1d513df8@bootlin.com/ Thanks, -michael > Note that given that the Flag Status Register (FSR) handling is the same > as in some micron devices, we're adding the issi chip directly on the > micron-st driver. > > Link: https://www.issi.com/WW/pdf/25LX-WX01GB.pdf > Signed-off-by: Nuno Sá