mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: phasta@kernel.org, "Gary Guo" <gary@garyguo.net>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>
Cc: <linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] dma-buf/dma-fence: Prevent misordering for error checks
Date: Wed, 18 Nov 2026 13:49:01 +0000	[thread overview]
Message-ID: <DMYDUJ95PGL5.1QXZ1EK86KC5R@garyguo.net> (raw)
In-Reply-To: <3792b7f8f4729820a924e0d60d17c97489827732.camel@mailbox.org>

On Wed Nov 18, 2026 at 1:15 PM GMT, Philipp Stanner wrote:
> On Wed, 2026-11-18 at 12:59 +0000, Gary Guo wrote:
>> On Wed Nov 18, 2026 at 11:09 AM GMT, Philipp Stanner wrote:
>
> […]
>
>> >  static inline bool
>> >  dma_fence_test_signaled_flag(struct dma_fence *fence)
>> >  {
>> > -	return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
>> > +	/*
>> > +	 * Best-effort ordering of the locklessly evaluated signaled-bit,
>> > +	 * especially so that reads of fence->error are not misordered.
>> 
>> I am not sure if this should focus on the error, or it should just provide a
>> general guarantee that anything happens before dma_fence_signal is visible when
>> signal test returns true. I would lean on the latter?
>
> See below.
>
>> 
>> > +	 *
>> > +	 * The release counterpart is typically ensured like this:
>> > +	 *   a) Error codes must only be set before a fence signals and
>> > +	 *   b) The fence's spinlock's barriers effective in dma_fence_signal()
>> > +	 *      ensure ordering.
>> 
>> Spinlock has nothing to do with this. The only thing that guarantees the
>> ordering is test_and_set_bit in (c).
>
> Why not? A spinlock includes full barriers. If it were set_bit()
> instead of test_and_set_bit(), it would still work.

No. spin_lock is a marked acquire access and spin_unlock is a marked release
access. The order guarantee for these are restricted to the spinlock variable
only (there is no acquire or release barriers in the kernel).

If you need to establish order using spinlock, you can only establish it with

    CPU 0  A --> spin_unlock 
                            \
                             \
                              \
    CPU 1                     spin_lock -> B

You cannot establish relation just by putting some atomic operation inside
spinlock critical sections.

You can make spin_lock a full barrier by using smp_mb__after_spinlock(), but
it's not there. I also think it's much easier to reason about test_bit_acquire()
pairing with test_and_set_bit() than "this code will only be executed after a
spin_lock".

>> 
>> So probably easier just to say something like
>> 
>>     /* Pairs with test_and_set_bit() in dma_fence_signal_timestamp_locked */
>
> It is easier.
>
> I am, however, unhappy with the unclear state of the API contract. It's
> still unclear what the signaled-flag even is supposed to mean. So this
> comment was also supposed to hint at the unclear state.
>
> The desired meaning aimed for by Christian is that it's only meaning is
> "hardware is done".

Hmm, if the dma-fence doesn't provide ordering guarantee, then how would a
consumer get ordering guarantee without knowing about the implementation detail on
the producer side?

To me it seems that providing ordering guarantee that "when a DMA fence is
observed to be signaled, everything prior to dma_fence_signal is visible"
wouldn't be that expensive to implement (practically just need to upgrade a few
test_bit to test_bit_acquire).

Best,
Gary

>
> But as we see here it has implications for the entire semantic, too:
> a) signaled == true -> the error code is valid (what else?)
> b) The fence has either signaled or "is still signaling", i.e. running
> callbacks
>
> I still maintain the position that it is inconsistent to run
> test_and_set_bit() under lock protection and evaluate it without the
> lock. Should be one or the other, not both.
>
> Note that this patch intends just to hot-fix the error code evaluation,
> not to make the fence API fully consistent. It's currently not even
> clear whether manual flag evaluation is legal. It used to be legal. I'm
> the one who added dma_fence_test_signaled_flag(), but mostly for
> readability, not for semantic correctness.
>
> It should be illegal to evaluate error codes with anything other than
> dma_fence_get_status(). But there then the meaning of the spinlock is
> currently also undefined. The lock there, with the current thinking,
> would seem surplus with this patch here.
>
>
> P.



      reply	other threads:[~2026-11-18 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:09 Philipp Stanner
2026-11-18 12:59 ` Gary Guo
2026-11-18 13:15   ` Philipp Stanner
2026-11-18 13:49     ` Gary Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYDUJ95PGL5.1QXZ1EK86KC5R@garyguo.net \
    --to=gary@garyguo.net \
    --cc=aliceryhl@google.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=phasta@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®