mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Thorsten Leemhuis" <linux@leemhuis.info>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	<stable@vger.kernel.org>
Cc: <patches@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<torvalds@linux-foundation.org>, <akpm@linux-foundation.org>,
	<linux@roeck-us.net>, <shuah@kernel.org>, <patches@kernelci.org>,
	<lkft-triage@lists.linaro.org>, <pavel@nabladev.com>,
	<jonathanh@nvidia.com>, <f.fainelli@gmail.com>,
	<sudipm.mukherjee@gmail.com>, <rwarsow@gmx.de>,
	<conor@kernel.org>, <hargar@microsoft.com>, <broonie@kernel.org>,
	<achill@achill.org>, <sr@sladewatkins.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"RUST" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 7.3 0000/2651] 7.3.6-rc1 review
Date: Wed, 18 Nov 2026 20:39:22 +0000	[thread overview]
Message-ID: <DMYMKQ2PRN7X.WKDSQ4X8JIFB@garyguo.net> (raw)
In-Reply-To: <cb9ff126-7767-4c60-b735-1b7890a247fc@leemhuis.info>

On Wed Nov 18, 2026 at 7:02 PM GMT, Thorsten Leemhuis wrote:
> On 11/18/26 15:20, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 7.3.6 release.
>> There are 2651 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>> 
>> Responses should be made by Fri, 20 Nov 2026 14:55:47 +0000.
>> Anything received after that time might be too late.
>> 
>> The whole patch series can be found in one patch at:
>> 	https://www.kernel.org/pub/linux/kernel/v7.x/stable-review/patch-7.3.6-rc1.gz
>> [...]
>
> This failed to build for me due to a problem with rust during the "make
> bzimage" stage:
>
> """> error[E0432]: unresolved import `crate::util`
>>   --> rust/pin-init/internal/src/init.rs:17:5
>>    |
>> 17 |     util::*,
>>    |     ^^^^ could not find `util` in the crate root
>> 
>> error[E0599]: no method named `extract_cfg_attrs` found for struct `Vec<Attribute>` in the current scope
>>    --> rust/pin-init/internal/src/init.rs:171:39
>>     |
>> 171 |                 let cfg = field.attrs.extract_cfg_attrs();
>>     |                                       ^^^^^^^^^^^^^^^^^
>>     |
>> help: there is a method `extract_if` with a similar name, but with different arguments
>>    --> library/alloc/src/vec/mod.rs:4245:4
>> 
>> error[E0599]: no method named `as_ident` found for reference `&Member` in the current scope
>>    --> rust/pin-init/internal/src/init.rs:413:28
>>     |
>> 413 |         let ident = member.as_ident();
>>     |                            ^^^^^^^^ method not found in `&Member`
>> 
>> error: aborting due to 3 previous errors
>> 
>> Some errors have detailed explanations: E0432, E0599.
>> For more information about an error, try `rustc --explain E0432`.
>> make[2]: *** [rust/Makefile:649: rust/libpin_init_internal.so] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [/builddir/build/BUILD/kernel-7.3.6-build/kernel-7.3.6-rc1/linux-7.3.6-0.rc1.400.vanilla.fc45.x86_64/Makefile:1440: prepare] Error 2

It looks like there's missing dependency not picked for pin-init changes.

Greg, can you drop

    [PATCH 7.3 0580/2651] rust: pin-init: internal: init: emit `slot` using mixed site hygiene
    [PATCH 7.3 0579/2651] rust: pin-init: internal: init: support tuple struct constructor syntax
    [PATCH 7.3 0578/2651] rust: pin-init: internal: init: support tuple structs in `[pin_]init!`

? While patch 0580 is a fix, pin-init is not used in a way that manifested the
issue in 7.3, so it's simpler to just drop it and the other two picked as dep of
it.

Best,
Gary

>> make: *** [Makefile:256: __sub-make] Error 2
> """
> Full log:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc/fedora-45-x86_64/11350094-stablerc-fedorarc-releases/builder-live.log.gz
>
> Have to run, so not time to look at where this is coming from right now,
> sorry.
>
> Ciao, Thorsten



  reply	other threads:[~2026-11-18 20:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:20 Greg Kroah-Hartman
2026-11-18 16:59 ` Brett A C Sheffield
2026-11-18 17:17 ` Pavel Machek
2026-11-18 19:02 ` Thorsten Leemhuis
2026-11-18 20:39   ` Gary Guo [this message]
2026-11-18 19:08 ` Thorsten Leemhuis
2026-11-18 19:59 ` Florian Fainelli
2026-11-18 22:30 ` Takeshi Ogasawara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYMKQ2PRN7X.WKDSQ4X8JIFB@garyguo.net \
    --to=gary@garyguo.net \
    --cc=achill@achill.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=conor@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hargar@microsoft.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=linux@roeck-us.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=ojeda@kernel.org \
    --cc=patches@kernelci.org \
    --cc=patches@lists.linux.dev \
    --cc=pavel@nabladev.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=rwarsow@gmx.de \
    --cc=shuah@kernel.org \
    --cc=sr@sladewatkins.com \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®