From: "Abdurrahman Hussain" <abdurrahman@nexthop.ai>
To: "Rob Herring" <robh@kernel.org>
Cc: "Saravana Kannan" <saravanak@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Shawn Guo" <shawnguo@kernel.org>,
"Grant Likely" <grant.likely@secretlab.ca>,
"Grant Likely" <grant.likely@linaro.org>,
"Pantelis Antoniou" <pantelis.antoniou@konsulko.com>,
"David Daney" <david.daney@cavium.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/6] of/overlay: look up absolute target-paths absolutely
Date: Wed, 18 Nov 2026 18:59:36 -0800 [thread overview]
Message-ID: <DMYUNULEK2SL.3XF7JGBDKUWR@nexthop.ai> (raw)
In-Reply-To: <20261118155103.GA2141649-robh@kernel.org>
On Wed, Nov 18, 2026 at 09:51:03AM -0600, Rob Herring wrote:
> The current behavior seems correct to me. The overlay should not modify
> anything above target_base. Correct or not, couldn't someone be relying
> on current behavior?
Out of tree, yes. In tree, lan966x_pci is the only caller that passes a
base, and it only uses an empty target-path.
This patch exists only for /aliases, so whether it is needed at all
depends on whether you want aliases from overlays in some form. The
case is a driver applying an overlay with its own device node as the
base:
fragment@0 {
target-path = "";
__overlay__ {
m0: i2c@1000 { ... };
};
};
fragment@1 {
target-path = "/aliases";
__overlay__ {
i2c16 = &m0;
};
};
Today fragment@1 resolves to <base>/aliases, which doesn't exist, and
the apply fails. The options I have looked at:
1) This patch: a non-empty target-path is absolute. It changes the
behavior for existing users, as you point out.
2) Leave target-path alone and handle a top-level "aliases" node in
the overlay the way "__symbols__" is handled, which already goes to
the live /__symbols__ regardless of the base:
fragment@0 { ... };
aliases {
i2c16 = &m0;
};
Such a node is ignored today, so nothing existing changes.
3) Apply with a NULL base. The overlay then has to hard-code the path
of the PCI device node, which depends on the slot.
I'd lean towards 2 and drop this patch, but I'd rather follow your
lead here. Which direction, if any, would you accept?
> If we are going to improve this, it should also define what NULL
> @target_base means.
Will do, if the kernel-doc change stays.
Thanks for applying 2/6.
Abdurrahman
next prev parent reply other threads:[~2026-11-19 2:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 23:17 [PATCH v8 0/6] of: teach overlay code to keep /aliases in sync Abdurrahman Hussain
2026-10-14 23:17 ` [PATCH v8 1/6] of/overlay: look up absolute target-paths absolutely Abdurrahman Hussain
2026-11-18 15:51 ` Rob Herring
2026-11-19 2:59 ` Abdurrahman Hussain [this message]
2026-10-14 23:17 ` [PATCH v8 2/6] of/overlay: return ERR_PTR from dup_and_fixup_symbol_prop() Abdurrahman Hussain
2026-11-18 15:53 ` Rob Herring
2026-10-14 23:17 ` [PATCH v8 3/6] of: hold a reference on of_aliases during alias path resolution Abdurrahman Hussain
2026-10-14 23:17 ` [PATCH v8 4/6] of: update /aliases lookup on reconfig notifications Abdurrahman Hussain
2026-10-14 23:17 ` [PATCH v8 5/6] of/overlay: rewrite /aliases path values to live-tree paths Abdurrahman Hussain
2026-10-14 23:17 ` [PATCH v8 6/6] of: unittest: cover /aliases updates from overlay apply/revert Abdurrahman Hussain
2026-11-05 0:09 ` [PATCH v8 0/6] of: teach overlay code to keep /aliases in sync Abdurrahman Hussain
2026-11-05 12:40 ` Rob Herring
2026-11-06 2:11 ` Abdurrahman Hussain
2026-11-06 13:24 ` Rob Herring
2026-11-06 19:51 ` Abdurrahman Hussain
2026-11-12 22:12 ` Rob Herring
2026-11-13 1:23 ` Abdurrahman Hussain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYUNULEK2SL.3XF7JGBDKUWR@nexthop.ai \
--to=abdurrahman@nexthop.ai \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®